Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JiriLojda
approved these changes
Jan 29, 2026
biome.jsonc
Outdated
| "linter": { | ||
| "rules": { | ||
| "a11y": { | ||
| "useValidAnchor": "off" // remove as this is a demo not showcasing navigaition |
Member
There was a problem hiding this comment.
Why "remove"? I understand why this is ignored, just the comment is a bit confusing to me. What about "Ignored, because the demo doesn't need working navigation"?
package.json
Outdated
| "fmt": "dprint fmt", | ||
| "fmt:check": "dprint check", | ||
| "format": "biome format --write .", | ||
| "format:check": "biome format .", |
Member
There was a problem hiding this comment.
The biome check command actually checks both, formatting and linting so another format command is not necessary. I don't mind this, but am actually leaning towards having just check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Update dependencies for kickstart. Adjust code according to biome and eslint.
Checklist
How to test
If manual testing is required, what are the steps?