fix(button): block clicks and ENTER/SPACE on disabled anchor hosts (#DS-4364)#1630
Open
lskramarov wants to merge 6 commits into
Open
fix(button): block clicks and ENTER/SPACE on disabled anchor hosts (#DS-4364)#1630lskramarov wants to merge 6 commits into
lskramarov wants to merge 6 commits into
Conversation
|
Visit the preview URL for this PR (updated for commit f33bd81): https://koobiq-next--prs-1630-6vtwb8ip.web.app (expires Tue, 16 Jun 2026 16:34:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
🚨 E2E tests failedReview the report for details. 💡 Comment |
🚨 E2E tests failedReview the report for details. 💡 Comment |
Contributor
Author
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
…et aria-disabled (#DS-4364)
…DS-4364) - extend the disabled keydown guard to DOWN/LEFT/RIGHT arrows, not just ENTER/SPACE, since KbqDropdownTrigger also opens on those (Tab/Escape left untouched so focus can still leave a disabled but focusable <a kbq-button> host); fix the misleading comment - dedupe the COMMENT_NODE literal by reusing getNodesWithoutComments at both levels - tests: assert a disabled dropdown trigger stays closed on click/ENTER/SPACE/arrow (guards stopImmediatePropagation), the effect()-driven reveal while the content observer is disabled, aria-disabled removal on re-enable, parentTextElement wrapping textElement, and the dev-mode warning when the styler is used without KbqButton
# Conflicts: # packages/components/sidepanel/__screenshots__/03-light.png
🚨 E2E tests failedReview the report for details. 💡 Comment |
Contributor
Author
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.