Add support for the Tolino Shine 4, and a proper light controller for the B300 Tolino devices

[hanakomisa]

This is a continuation of PR #568, as always, the original light controller code was pulled from PR #520, fixed up to work with the current codebase, as well as adding more things to handle the different properties of the Shine 4 and Vision 6.

Original light controller code credit to dboleslawski. Vision 6 has been personally tested. Thanks to Waldy for testing the Epos 3 and Shine 4 for me. Shine 4 has been confirmed to be fully supported with this commit (Light/E-ink), Epos 3 light controls also work with no issues.

As per those two PRs, same caveats apply.

1. E-ink controller only works on the B300 Tolinos when the persist.mode.global property is 0. This has been the case for the Vision 6 and Epos 3 already, so there shouldn't be any qualms of me adding NGL4 driver support to the Shine 4.
2. The light controller requires "Modify System Settings" permission to be turned on. I have added a check for the permission and have it display a toast saying "Please enable 'Modify system settings' for KOReader in Android settings." if WRITE_SETTINGS permission isn't granted when you try to change the brightness/warmth.

Originally, I had tried implementing an intent launch to the correct Settings page if the permission hasn't been granted, however, when I return to KOReader, the app crashes and I feel like fixing that ANR crash would be far outside the scope of this PR, therefore I have decided to settle with just a notification toast warning you about it.

Once this PR goes through, I will open another in the main KOReader repo to update the wiki accordingly, also mentioning the E-ink driver quirk so those with B300 Tolinos can find out why the E-ink controller doesn't refresh their screen.

---

This change is 

[hanakomisa]

@hugleo @pazos I assume we're good to merge?

[hugleo]

Should Codacy be fixed in this case? https://app.codacy.com/gh/koreader/android-luajit-launcher/pull-requests/570/complexity

[Frenzie]

I don't see how you would. ;-)

[hugleo]

My only complaint is whether this is the better way to implement needsInvertedWarmth, import DeviceInfo for lights.

android-luajit-launcher/app/src/main/java/org/koreader/launcher/device/lights/TolinoB300Controller.kt

Line 25 in 374535d

private fun needsInvertedWarmth(): Boolean {

[hanakomisa]

My only complaint is whether this is the better way to implement needsInvertedWarmth, import DeviceInfo for lights.

android-luajit-launcher/app/src/main/java/org/koreader/launcher/device/lights/TolinoB300Controller.kt

Line 25 in 374535d

private fun needsInvertedWarmth(): Boolean {

How exactly do you mean by this? I'm not sure how else I would go about implementing it seeing this is basically my first time writing kotlin (and basically my second time writing code in general lol)

[hugleo]

This works, it's just a matter of making the code modular.

Some tolino devices are identified using files on device firmware:

android-luajit-launcher/app/src/main/java/org/koreader/launcher/device/lights/TolinoRootController.kt

Line 26 in d676dd6

private val COLOR_FILE = if (File(COLOR_FILE_VISION4HD).exists())

I don't know if it's better to import DeviceInfo into lights since the implementation is separated for device match, or if it should use an additional driver for the inverted warmth, or maybe try another trick like the Tolino root driver. That's why I asked @pazos to opinate.

[hugleo]

Well, if there are any complaints or problems with needsInvertedWarmth in the future, it’s always possible to use android.os.Build.MODEL properties directlly or a separate driver file for each device...

[hanakomisa]

I suppose. I'm not sure if its more efficient to more or less duplicate the code to handle the Shine4/Vision 6 and separate Epos3 into its own thing though.

From what I know, the B300 Tolinos all use the exact same firmware (with differences under /dev presumably), I'll look into what options I have and see. Not having the Epos3 to check makes it a little more difficult.