Skip to content

fix(lvm-driver): adjust vg selection strategy #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(lvm-driver): adjust vg selection strategy #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/mgmt/volume/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func Start(controllerMtx *sync.RWMutex, stopCh <-chan struct{}) error {
go VolInformerFactory.Start(stopCh)
klog.Info("Starting Lvm volume controller")
// Threadiness defines the number of workers to be launched in Run function
return controller.Run(2, stopCh)
return controller.Run(1, stopCh)
}

// GetClusterConfig return the config for k8s.
Expand Down
4 changes: 2 additions & 2 deletions pkg/mgmt/volume/volume.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,9 @@ func (c *VolController) getVgPriorityList(vol *apis.LVMVolume) ([]apis.VolumeGro
filteredVgs = append(filteredVgs, vg)
}

// prioritize the volume group having less free space available.
// prioritize the volume group having most free space available.
sort.SliceStable(filteredVgs, func(i, j int) bool {
return filteredVgs[i].Free.Cmp(filteredVgs[j].Free) < 0
return filteredVgs[i].Free.Cmp(filteredVgs[j].Free) > 0
})
return filteredVgs, nil
}
Expand Down