Skip to content

Update the base branch to mvp_demo#96

Merged
chandrams merged 2 commits into
kruize:mvp_demofrom
shreyabiradar07:update_base_branch
May 11, 2026
Merged

Update the base branch to mvp_demo#96
chandrams merged 2 commits into
kruize:mvp_demofrom
shreyabiradar07:update_base_branch

Conversation

@shreyabiradar07
Copy link
Copy Markdown
Contributor

@shreyabiradar07 shreyabiradar07 commented May 11, 2026

This PR updates sync-kruize-versions GH workflow to use mvp_demo as the base branch to raise new PRs updating the Kruize version.

Summary by Sourcery

CI:

  • Update the sync-kruize-versions workflow to use mvp_demo as the base branch when creating automated version bump pull requests.

Signed-off-by: Shreya Biradar <shbirada@ibm.com>
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 11, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the sync-kruize-versions GitHub Actions workflow so that automated Kruize version bump pull requests always target the mvp_demo branch instead of the workflow’s triggering ref.

Sequence diagram for creating PR with fixed mvp_demo base branch

sequenceDiagram
  actor Developer
  participant GitHub as GitHub_Repo
  participant Workflow as sync_kruize_versions_Workflow
  participant API as GitHub_API

  Developer->>GitHub: Push or scheduled event on any ref
  GitHub-->>Workflow: Trigger workflow run

  Workflow->>API: Get SHA for base branch mvp_demo
  API-->>Workflow: Return mvp_demo SHA

  Workflow->>API: Create branch automated_bump_kruize_versions
  API-->>Workflow: Branch created

  Workflow->>API: Create pull request
  Note right of Workflow: base_branch = mvp_demo<br/>head_branch = automated_bump_kruize_versions
  API-->>Workflow: PR created

  Workflow-->>GitHub: Expose PR link
  GitHub-->>Developer: Show PR targeting mvp_demo
Loading

File-Level Changes

Change Details Files
Pin the base branch for automated Kruize version bump PRs to the mvp_demo branch.
  • Set BASE_BRANCH to the literal mvp_demo value when creating the temporary bump branch in the workflow script.
  • Set BASE_BRANCH to the literal mvp_demo value when constructing the pull request from the created branch.
.github/workflows/sync-kruize-versions.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Hardcoding BASE_BRANCH="mvp_demo" reduces flexibility of the workflow; consider making the base branch configurable (e.g., via a workflow input or repository/environment variable) so the same workflow can be reused across branches or easily updated later.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Hardcoding `BASE_BRANCH="mvp_demo"` reduces flexibility of the workflow; consider making the base branch configurable (e.g., via a workflow input or repository/environment variable) so the same workflow can be reused across branches or easily updated later.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Signed-off-by: Shreya Biradar <shbirada@ibm.com>
@shreyabiradar07
Copy link
Copy Markdown
Contributor Author

Hey - I've left some high level feedback:

* Hardcoding `BASE_BRANCH="mvp_demo"` reduces flexibility of the workflow; consider making the base branch configurable (e.g., via a workflow input or repository/environment variable) so the same workflow can be reused across branches or easily updated later.

Prompt for AI Agents

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Removed hardcoded branch and enabled input base branch configuration.

Copy link
Copy Markdown
Contributor

@chandrams chandrams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chandrams chandrams merged commit 10ae959 into kruize:mvp_demo May 11, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from Under Review to Done in Monitoring May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants