Update the base branch to mvp_demo#96
Merged
Merged
Conversation
Signed-off-by: Shreya Biradar <shbirada@ibm.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the sync-kruize-versions GitHub Actions workflow so that automated Kruize version bump pull requests always target the mvp_demo branch instead of the workflow’s triggering ref. Sequence diagram for creating PR with fixed mvp_demo base branchsequenceDiagram
actor Developer
participant GitHub as GitHub_Repo
participant Workflow as sync_kruize_versions_Workflow
participant API as GitHub_API
Developer->>GitHub: Push or scheduled event on any ref
GitHub-->>Workflow: Trigger workflow run
Workflow->>API: Get SHA for base branch mvp_demo
API-->>Workflow: Return mvp_demo SHA
Workflow->>API: Create branch automated_bump_kruize_versions
API-->>Workflow: Branch created
Workflow->>API: Create pull request
Note right of Workflow: base_branch = mvp_demo<br/>head_branch = automated_bump_kruize_versions
API-->>Workflow: PR created
Workflow-->>GitHub: Expose PR link
GitHub-->>Developer: Show PR targeting mvp_demo
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Hardcoding
BASE_BRANCH="mvp_demo"reduces flexibility of the workflow; consider making the base branch configurable (e.g., via a workflow input or repository/environment variable) so the same workflow can be reused across branches or easily updated later.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Hardcoding `BASE_BRANCH="mvp_demo"` reduces flexibility of the workflow; consider making the base branch configurable (e.g., via a workflow input or repository/environment variable) so the same workflow can be reused across branches or easily updated later.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Shreya Biradar <shbirada@ibm.com>
Contributor
Author
Removed hardcoded branch and enabled input base branch configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates sync-kruize-versions GH workflow to use
mvp_demoas the base branch to raise new PRs updating the Kruize version.Summary by Sourcery
CI: