Conversation
Signed-off-by: Shreya Biradar <shbirada@ibm.com>
Signed-off-by: Shreya Biradar <shbirada@ibm.com>
Signed-off-by: Shreya Biradar <shbirada@ibm.com>
Signed-off-by: Shreya Biradar <shbirada@ibm.com>
Signed-off-by: Shreya Biradar <shbirada@ibm.com>
Signed-off-by: Shreya Biradar <shbirada@ibm.com>
Signed-off-by: Shreya Biradar <shbirada@ibm.com>
Signed-off-by: Shreya Biradar <shbirada@ibm.com>
Update Dependencies to Fix CVEs
Signed-off-by: kruize-version-sync <2884050+kruize-version-sync[bot]@users.noreply.github.com>
Signed-off-by: Shreya Biradar <shbirada@ibm.com>
Signed-off-by: Shreya Biradar <shbirada@ibm.com>
build(deps): update Kruize image versions
Update the base branch to mvp_demo
Signed-off-by: Shreya Biradar <shbirada@ibm.com>
Signed-off-by: Shreya Biradar <shbirada@ibm.com>
Update bundle files and bump kruize-operator 0.0.6
Reviewer's GuideBumps the operator to version 0.0.6, aligning Go/toolchain, base images, manifests, docs, and GitHub automation with the new release and newer upstream libraries. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- There are multiple hard-coded version strings for the operator and related images (e.g., 0.0.6, autotune 0.10) across manifests, samples, constants, and the Makefile; consider centralizing these in a single source (or a small set of well-defined sources) to reduce the risk of version drift in future bumps.
- In
.github/workflows/sync-kruize-versions.yml, the defaultBASE_BRANCHis hard-coded tomvp_demoeven for scheduled runs; consider deriving the default from the triggering ref or validating/overriding it per use case so the workflow behaves correctly when run against other branches (e.g.,main).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There are multiple hard-coded version strings for the operator and related images (e.g., 0.0.6, autotune 0.10) across manifests, samples, constants, and the Makefile; consider centralizing these in a single source (or a small set of well-defined sources) to reduce the risk of version drift in future bumps.
- In `.github/workflows/sync-kruize-versions.yml`, the default `BASE_BRANCH` is hard-coded to `mvp_demo` even for scheduled runs; consider deriving the default from the triggering ref or validating/overriding it per use case so the workflow behaves correctly when run against other branches (e.g., `main`).
## Individual Comments
### Comment 1
<location path="go.mod" line_range="67-68" />
<code_context>
- go.opentelemetry.io/otel v1.35.0 // indirect
+ go.opentelemetry.io/auto/sdk v1.2.1 // indirect
+ go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.68.0 // indirect
+ go.opentelemetry.io/otel v1.43.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.34.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.34.0 // indirect
- go.opentelemetry.io/otel/metric v1.35.0 // indirect
</code_context>
<issue_to_address>
**issue (bug_risk):** OpenTelemetry core and exporter versions are out of sync and may introduce subtle runtime issues.
Core OTel packages are now at v1.43.0 while the OTLP trace exporters remain at v1.34.0. OTel recommends keeping all components on the same major+minor version to avoid API/behavior mismatches. Please either upgrade the exporters to v1.43.0 or keep all OTel modules aligned on a single version.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge
0.0.6release frommvp_demotomainbranchSummary by Sourcery
Update kruize-operator to version 0.0.6 with refreshed images, tooling, and documentation for the new release.
Enhancements:
Build:
CI:
Documentation: