Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
d4e38e9
Delete pull_request_template.md
kryptodrex Mar 14, 2026
084b93a
Create copilot-instructions.md
kryptodrex Mar 14, 2026
31b88a2
Add utils/tests; use ViewMode in payPeriod
kryptodrex Mar 14, 2026
f514fe6
Split types into individual files
kryptodrex Mar 14, 2026
c00ba14
Add paycheck calculations and integrate in PDF
kryptodrex Mar 14, 2026
57f8e82
Use shared utilities for plan name and paychecks
kryptodrex Mar 14, 2026
d98a0f8
Refactor display mode conversions & use ViewMode
kryptodrex Mar 14, 2026
d80eab1
Refactor type imports to domain-specific files
kryptodrex Mar 14, 2026
be29d10
Save defaults when stored accounts invalid
kryptodrex Mar 14, 2026
b3573b2
Add file relink flow hook and tests
kryptodrex Mar 14, 2026
5ead263
Add FileRelinkModal and integrate relink flow
kryptodrex Mar 14, 2026
5ccf513
Throw error on max decryption attempts
kryptodrex Mar 14, 2026
ac41ea5
Add useAppDialogs hook and tests
kryptodrex Mar 14, 2026
ebd51d5
Use ErrorDialog via useAppDialogs in BudgetContext
kryptodrex Mar 14, 2026
c573708
Introduce Confirm/Error dialogs and useAppDialogs
kryptodrex Mar 14, 2026
92e74a1
removed unused code
kryptodrex Mar 14, 2026
7633c7c
Add modal editor and field errors hooks
kryptodrex Mar 14, 2026
b65fe90
Use modal editor and field-errors hooks
kryptodrex Mar 14, 2026
abe65cf
Add account grouping utils and tests
kryptodrex Mar 14, 2026
86b3165
Use account grouping utilities in managers
kryptodrex Mar 14, 2026
967759b
Extract budget currency conversion to service
kryptodrex Mar 14, 2026
c81558d
Extract shared path display CSS
kryptodrex Mar 14, 2026
ca51e27
Remove backup files and BenefitsManager references
kryptodrex Mar 14, 2026
1a4ed85
moved files to _shared
kryptodrex Mar 14, 2026
e1693cd
Changed components folder organization
kryptodrex Mar 14, 2026
4e55247
Update README to reflect UI folder refactor
kryptodrex Mar 14, 2026
05d35e5
Centralize menu and storage constants
kryptodrex Mar 14, 2026
f5de3d7
Introduce useEncryptionSetupFlow hook
kryptodrex Mar 14, 2026
d70a100
Update Shared Logic Refactor.md
kryptodrex Mar 14, 2026
1d69dd0
remove completed update files
kryptodrex Mar 14, 2026
27e0347
Merge branch 'develop' into issue/shared-logic-refactor
kryptodrex Mar 14, 2026
f3772be
Refactor EncryptionSetup into shared/views
kryptodrex Mar 14, 2026
7790c8e
Update version
kryptodrex Mar 14, 2026
5c38ae9
Use STORAGE_KEYS, import BudgetData, add locale
kryptodrex Mar 14, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions .github/copilot-instructions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# Paycheck Planner Copilot Instructions

## PR Review Expectations

When asked to review a PR, pull request diff, or changeset, default to a PR review mindset focused on merge risk, regressions, and missing validation. This project is an Electron + React + TypeScript desktop app built with Vite, so reviews should favor focused root-cause fixes that preserve existing architecture, shared primitives, and established UX patterns unless the change explicitly justifies something broader.

- Prioritize findings over summaries.
- Focus first on bugs, behavioral regressions, data loss risks, invalid file acceptance, persistence issues, and missing or insufficient tests.
- Call out platform-specific risks for Electron, especially file handling, keyboard shortcuts, native integrations, and packaging/signing behavior.
- Identify when a change duplicates logic that should live in a shared utility, hook, service, or component.
- Flag changes that bypass existing shared UI primitives such as `Modal`, `Button`, `Toast`, and other shared form or layout components without a clear reason.
- Prefer fixes at the service or state-management boundary when the PR only patches symptoms in the UI.
- Flag styling changes that drift from the current visual language or introduce broad CSS selectors instead of component-scoped selectors.
- Flag globally scoped CSS that risks collisions across screens.
- Treat file operations as safety-critical. Call out regressions in moved-file relink behavior, acceptance of non-plan files such as settings exports, or save flows that can target stale or missing file paths.
- Preserve the existing two-tier keyboard shortcut model: Electron/global shortcuts for app-level reliability and React capture-phase listeners as renderer fallback. Treat bubbling-only handlers for critical shortcuts as a review risk.
- Treat missing test coverage for changed `src/services` or `src/utils` files as a review finding unless there is a strong reason not to add tests.
- Treat a new file in `src/services` or `src/utils` without a corresponding `*.test.ts` file as a review finding.
- Treat changed logic in an existing `src/services` or `src/utils` file without corresponding updates to its existing tests as a review finding.
- Check that new behavior added to existing service or util modules is explicitly exercised by tests, not only covered indirectly by unrelated suites.
- Prefer mock-based tests for services that touch Electron APIs, file system behavior, or keychain behavior.
- Flag dependency or build changes in the package.json or Vite config that are not clearly justified by the PR description or that introduce new risks without clear mitigation.
- If a PR includes a dependency update, check the changelog for that dependency for any breaking changes or new risks that should be called out in the review.

## Review Response Format

- Present findings first, ordered by severity.
- Include concrete file references whenever possible.
- Keep summaries brief and secondary.
- When it makes sense, give a brief explanation of the root cause or reasoning behind a finding, but avoid long-winded explanations when the issue is straightforward.
- For each finding, if possible, suggest a specific fix or improvement rather than just flagging the issue.
- If no issues are found, state that explicitly and mention any residual risks or validation gaps.

## Collaboration Style

- Be direct, concise, and technical.
- Do useful work without unnecessary back-and-forth when the task is clear.
- If there are unrelated local changes, do not revert them unless explicitly asked.
- If user changes conflict with the current task, stop and ask before overwriting them.
25 changes: 0 additions & 25 deletions .github/pull_request_template.md

This file was deleted.

64 changes: 0 additions & 64 deletions app_updates/APP_MVP.md

This file was deleted.

84 changes: 0 additions & 84 deletions app_updates/APP_UPDATES.md

This file was deleted.

Loading
Loading