update documentation to include installation with in-cluster prometheus in openshift #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipzoller
previously requested changes
Oct 23, 2024
Contributor
chipzoller
left a comment
chipzoller
left a comment
There was a problem hiding this comment.
Thanks for doing this!
install-and-configure/install/provider-installations/openshift-kubecost-install.md
Outdated
Show resolved
Hide resolved
mittal-ishaan
force-pushed
the
openshift-prometheus
branch
from
c6f74a6 to
a51bff8
Compare
Contributor
|
Are all comments resolved? If so, please resolve. |
thomasvn
reviewed
Dec 17, 2024
install-and-configure/install/provider-installations/openshift-kubecost-install.md
Outdated
Show resolved
Hide resolved
thomasvn
reviewed
Dec 17, 2024
install-and-configure/install/provider-installations/openshift-kubecost-install.md
Outdated
Show resolved
Hide resolved
thomasvn
reviewed
Dec 17, 2024
install-and-configure/install/provider-installations/openshift-kubecost-install.md
Show resolved
Hide resolved
Co-authored-by: Thomas Nguyen <[email protected]>
thomasvn
approved these changes
Jan 27, 2025
thomasvn
dismissed
chipzoller’s stale review
Dismissing review, as the appropriate changes have now been made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Proposed Changes
This PR adds the documentation for installing kubecost in openshift clusters without having the bundled prometheus but using the in-cluster prometheus.
Depends upon:
opencost/opencost#2944
kubecost/kubecost#3700