Draft
Conversation
Signed-off-by: HMetcalfeW <106991365+HMetcalfeW@users.noreply.github.com>
thomasvn
approved these changes
Nov 20, 2025
Member
thomasvn
left a comment
There was a problem hiding this comment.
I'm open to trying this out! Especially if we just start with type validation in the schema.
My only minor hesitation is that any time we need to make fixes/updates to this schema, it will need to be accompanied by:
- A newly built finops-agent image & version
- An updated
Chart.yamlin the Kubecost helm chart, to consume this new subchart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interested in the team's feedback on adding a schema to our Helm Chart. The initial generation was relatively straightforward, but as our chart evolves, this file will require ongoing maintenance. If we think this is too much maintenance, then I'm happy to table it, but believe it can pay long-term dividends. This first iteration is lax because it lacks
requiredfields.The practice is fairly common in the Bitnami Charts community. There's a great blog post on the motivations behind creating a Values schema and the various checks it allows.
Since schema checks are run on all Helm commands (template, lint, upgrade, install), this helps prevent customer values from drifting too far between versions and clearly defines what values are/are not allowed.
Example Helm output using a number for
clusterIdhelm lint . --set global.clusterId=1234https://helm.sh/docs/helm/helm_lint/