fix: serve static assets with nginx instead of npm start#220
fix: serve static assets with nginx instead of npm start#220KUNDAN1334 wants to merge 2 commits intokubeflow:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
- /dist → /public/ (actual webpack output) - Copy app.bundle.js + app.css bundles - nginx.conf SPA routing preserved" Signed-off-by: KUNDAN1334 <kundan.22bcon1334@jecrcu.edu.in>
Signed-off-by: KUNDAN1334 <kundan.22bcon1334@jecrcu.edu.in>
20a841e to
2125f79
Compare
|
Did you test those changes by running the application? |
|
@KUNDAN1334 nice, thats already good to know! 🤗 please also test the UI itself and not just the outputs of the CLI tools 👍🏻 |
|
@christian-heusel ! Full UI test complete on Mac M4 + Kind v1.35.0 Test Environment:
|
|
any update @christian-heusel ?? |




Motivation
Current Dockerfile uses
npm start(Node.js server) in production:Changes
Dockerfile: Replace Node serve → nginx static serveCloses #211