Add istio virtualservice to katib external-db#2599
Add istio virtualservice to katib external-db#2599namejsjeongkr wants to merge 1 commit intokubeflow:masterfrom
Conversation
|
🎉 Welcome to the Kubeflow Katib repo! 🎉 Thanks for opening your first PR! We're excited to have you onboard 🚀 Next steps:
Feel free to ask questions in the comments. Thanks again for contributing! 🙏 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: namejsjeongkr namejsjeongkr@gmail.com Signed-off-by: JinSoo Jeong <namejsjeongkr@gmail.com>
b07ed63 to
63f4611
Compare
|
@andreyvelich for approval and review. |
|
@Electronic-Waste @gaocegege @johnugeorge Is there any someone can review and approve ? |
| # Kubeflow istio virtual service. | ||
| - ui-virtual-service.yaml |
There was a problem hiding this comment.
Why do we need it here if Katib already has virtualService for Kubeflow Platform installation: https://github.com/namejsjeongkr/katib/blob/63f4611b27912222636057fd3c70b8e3ffa3c37c/manifests/v1beta1/installs/katib-with-kubeflow/ui-virtual-service.yaml ?
There was a problem hiding this comment.
@andreyvelich Thank you for the review!
You're right:
katib-with-kubeflow: Full Kubeflow platform (embedded manifests) VS includedkatib-external-db: Standalone Katib + external PostgreSQL (custom MLOps) Missing VS
Real issue:
kustomize build katib-external-db | kubectl apply -f -
→ katib-ui pod healthy, but dashboard shows "Sorry, /katib/ is not a valid page"
This PR: Cherry-picks identical VS from katib-with-kubeflow → one-command Istio for standalone users.
What this PR does / why we need it:
Summary
Adds ui-virtual-service.yaml to enable automatic /katib/ UI routing for users deploying Katib with external databases.
Before: Users had to manually create Istio VirtualService after kustomize build manifests/v1beta1/installs/katib-external-db.
After: kustomize build automatically includes Istio integration
Motivation
Users of
katib-external-dbmust manually create VirtualService. This cherry-pickskatib-with-kubeflow/ui-virtual-service.yaml.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Checklist: