Skip to content

refactor: replace gomock with fake client in generator_test.go#2604

Open
haroon0x wants to merge 1 commit intokubeflow:masterfrom
haroon0x:area/testing
Open

refactor: replace gomock with fake client in generator_test.go#2604
haroon0x wants to merge 1 commit intokubeflow:masterfrom
haroon0x:area/testing

Conversation

@haroon0x
Copy link

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2408

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Haroon <106879583+haroon0x@users.noreply.github.com>
@github-actions
Copy link

🎉 Welcome to the Kubeflow Katib repo! 🎉

Thanks for opening your first PR! We're excited to have you onboard 🚀

Next steps:

Feel free to ask questions in the comments. Thanks again for contributing! 🙏

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace go mock with client-go fake client in unit tests

1 participant