feat(katib-sdk): support node_selector in Katib Python SDK#2606
Open
Priyanshu-u07 wants to merge 2 commits intokubeflow:masterfrom
Open
feat(katib-sdk): support node_selector in Katib Python SDK#2606Priyanshu-u07 wants to merge 2 commits intokubeflow:masterfrom
Priyanshu-u07 wants to merge 2 commits intokubeflow:masterfrom
Conversation
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow Katib repo! 🎉 Thanks for opening your first PR! We're excited to have you onboard 🚀 Next steps:
Feel free to ask questions in the comments. Thanks again for contributing! 🙏 |
1 task
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
Author
|
@andreyvelich please check once |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for configuring Kubernetes
nodeSelectorin the Katib Python SDK.Currently, users cannot control node placement for Katib trial pods when using the Python SDK, even though Kubernetes supports nodeSelector at the Pod level. This is especially limiting for workloads that require specific nodes (e.g. GPU, high-memory, or custom-labeled nodes).
The change introduces an optional
node_selectorparameter toKatibClient.tune(), which injects the provided nodeSelector into the TrialTemplate PodSpec. The scheduling is then handled natively by Kubernetes without requiring any backend changes.This improves flexibility and brings the Python SDK closer to feature parity with Kubernetes-native workflows.
Changes Included
Tests Included
Manual Verification
Installed Katib in a local Minikube cluster.
Labeled the node with a custom label (e.g. gpu=nvidia-a100).
Created a Katib experiment using KatibClient.tune() with the node_selector parameter.
Verified that Trial Pods were scheduled only on nodes matching the specified node selector using:
kubectl get pods -n kubeflow -oConfirmed that the nodeSelector field was correctly injected into the generated Trial PodSpec.
Fixes #2603
Checklist: