fix: Resolve JSONDecodeError in LLM fine-tuning tune() API#2610
Open
Priyanshu-u07 wants to merge 3 commits intokubeflow:masterfrom
Open
fix: Resolve JSONDecodeError in LLM fine-tuning tune() API#2610Priyanshu-u07 wants to merge 3 commits intokubeflow:masterfrom
Priyanshu-u07 wants to merge 3 commits intokubeflow:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow Katib repo! 🎉 Thanks for opening your first PR! We're excited to have you onboard 🚀 Next steps:
Feel free to ask questions in the comments. Thanks again for contributing! 🙏 |
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
cefc33f to
39cdc41
Compare
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the Katib Python SDK where LLM training parameters were passed as an improperly quoted JSON string when using the tune() API. The extra shell quoting caused the LLM worker pod (PyTorch container) to fail with a JSONDecodeError, preventing fine-tuning experiments from running correctly.
The implementation ensures that:
This resolves the LLM fine-tuning errors in the worker pod, allowing experiments using the tune() API to initialize and run successfully.
Changes Included
sdk/python/v1beta1/kubeflow/katib/api/katib_client.py:
sdk/python/v1beta1/kubeflow/katib/api/katib_client_test.py
Testing:
Fixes #2587
Checklist: