fix: inject Katib labels early to support PodDefaults for trial pods#2620
Open
Priyanshu-u07 wants to merge 1 commit intokubeflow:masterfrom
Open
fix: inject Katib labels early to support PodDefaults for trial pods#2620Priyanshu-u07 wants to merge 1 commit intokubeflow:masterfrom
Priyanshu-u07 wants to merge 1 commit intokubeflow:masterfrom
Conversation
Signed-off-by: Priyanshu-u07 <connect.priyanshu8271@gmail.com>
|
🎉 Welcome to the Kubeflow Katib repo! 🎉 Thanks for opening your first PR! We're excited to have you onboard 🚀 Next steps:
Feel free to ask questions in the comments. Thanks again for contributing! 🙏 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
@andreyvelich Could you please take a look when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a trial pod is created, Katib labels like
katib.kubeflow.org/trialare added too late . They get added by a webhook that runs after the PodDefaults webhook has already finished checking. Because of this timing issue, PodDefaults that depend on Katib labels are never applied to trial pods.This PR fixes it by adding the labels directly into the pod template before the pod is created, so PodDefaults can see them in time.
Changes:
Fixes #2548