Skip to content

Fix: specify list positional argument within search.categorical#2630

Open
Doel10 wants to merge 1 commit intokubeflow:masterfrom
Doel10:fix/search-categorical-list-arg
Open

Fix: specify list positional argument within search.categorical#2630
Doel10 wants to merge 1 commit intokubeflow:masterfrom
Doel10:fix/search-categorical-list-arg

Conversation

@Doel10
Copy link

@Doel10 Doel10 commented Mar 1, 2026

What this PR does / why we need it:
katib.search.categorical() incorrectly constructs V1beta1FeasibleSpace by passing the list value as positional argument mapping it to the distribution argument instead of list argument.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2625

Checklist:

  • Docs included if any changes are user facing

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign electronic-waste for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested a review from anencore94 March 1, 2026 17:00
@google-oss-prow google-oss-prow bot requested a review from helenxie-bit March 1, 2026 17:00
Signed-off-by: Doel10 <eliadorazio10@gmail.com>
@Doel10 Doel10 force-pushed the fix/search-categorical-list-arg branch from dec05c8 to 49f18a7 Compare March 1, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

katib.search.categorical incorrectly populates "distribution" instead of "list" in V1beta1FeasibleSpace causing webhook rejection

1 participant