refactor: move common component into each controller#702
Merged
google-oss-prow[bot] merged 1 commit intokubeflow:notebooks-v1from Nov 6, 2025
Merged
Conversation
google-oss-prow
bot
added
do-not-merge/work-in-progress
area/controller
…Components - Delete common component (OWNERS, go.mod, reconcilehelper/) - Copy reconcilehelper/util.go to both notebook-controller and tensorboard-controller - Update imports in both controllers to use local reconcilehelper - Remove common dependency from go.mod files - Update Dockerfiles to remove common component references Signed-off-by: Yehudit Kerido <ykerido@ykerido-thinkpadp1gen7.raanaii.csb>
yehuditkerido
force-pushed
the
remove_common_component
branch
2 times, most recently
from
9693766 to
e88a97e
Compare
Contributor
|
/ok-to-test |
Contributor
|
/lgtm confirmed the |
3 tasks
thesuperzapper
changed the title
Member
|
Thanks @yehudit1987 ! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
asaadbalum
added a commit
to asaadbalum/notebooks
that referenced
this pull request
Nov 9, 2025
…books - Updated module declarations in 3 go.mod files (notebook-controller, tensorboard-controller, pvcviewer-controller) - Updated all internal import statements in Go source files to match new module paths - Updated reconcilehelper imports to use local paths (after PR kubeflow#702 moved reconcilehelper into each controller) - Verified all components compile successfully Fixes kubeflow#699 Signed-off-by: Asaad Balum <asaad.balum@gmail.com>
google-oss-prow bot
pushed a commit
that referenced
this pull request
Nov 27, 2025
* chore: Update Go module paths from kubeflow/kubeflow to kubeflow/notebooks - Updated module declarations in 3 go.mod files (notebook-controller, tensorboard-controller, pvcviewer-controller) - Updated all internal import statements in Go source files to match new module paths - Updated reconcilehelper imports to use local paths (after PR #702 moved reconcilehelper into each controller) - Verified all components compile successfully Fixes #699 Signed-off-by: Asaad Balum <asaad.balum@gmail.com> * chore: Update PROJECT files to use kubeflow/notebooks paths - Updated all repo and API paths in PROJECT files - Changed pvcviewer projectName from 'pvc-viewer' to 'pvcviewer-controller' Addresses feedback from review Signed-off-by: Asaad Balum <asaad.balum@gmail.com> * mathew: fix rename of `pvc-viewer` path Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> --------- Signed-off-by: Asaad Balum <asaad.balum@gmail.com> Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
utruong309
pushed a commit
to utruong309/notebooks
that referenced
this pull request
Dec 8, 2025
- Delete common component (OWNERS, go.mod, reconcilehelper/) - Copy reconcilehelper/util.go to both notebook-controller and tensorboard-controller - Update imports in both controllers to use local reconcilehelper - Remove common dependency from go.mod files - Update Dockerfiles to remove common component references Signed-off-by: Yehudit Kerido <ykerido@ykerido-thinkpadp1gen7.raanaii.csb> Co-authored-by: Yehudit Kerido <ykerido@ykerido-thinkpadp1gen7.raanaii.csb> Signed-off-by: utruong309 <uyenthutruong09@gmail.com>
utruong309
pushed a commit
to utruong309/notebooks
that referenced
this pull request
Dec 8, 2025
* chore: Update Go module paths from kubeflow/kubeflow to kubeflow/notebooks - Updated module declarations in 3 go.mod files (notebook-controller, tensorboard-controller, pvcviewer-controller) - Updated all internal import statements in Go source files to match new module paths - Updated reconcilehelper imports to use local paths (after PR kubeflow#702 moved reconcilehelper into each controller) - Verified all components compile successfully Fixes kubeflow#699 Signed-off-by: Asaad Balum <asaad.balum@gmail.com> * chore: Update PROJECT files to use kubeflow/notebooks paths - Updated all repo and API paths in PROJECT files - Changed pvcviewer projectName from 'pvc-viewer' to 'pvcviewer-controller' Addresses feedback from review Signed-off-by: Asaad Balum <asaad.balum@gmail.com> * mathew: fix rename of `pvc-viewer` path Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> --------- Signed-off-by: Asaad Balum <asaad.balum@gmail.com> Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Signed-off-by: utruong309 <uyenthutruong09@gmail.com>
utruong309
pushed a commit
to utruong309/notebooks
that referenced
this pull request
Jan 8, 2026
- Delete common component (OWNERS, go.mod, reconcilehelper/) - Copy reconcilehelper/util.go to both notebook-controller and tensorboard-controller - Update imports in both controllers to use local reconcilehelper - Remove common dependency from go.mod files - Update Dockerfiles to remove common component references Signed-off-by: Yehudit Kerido <ykerido@ykerido-thinkpadp1gen7.raanaii.csb> Co-authored-by: Yehudit Kerido <ykerido@ykerido-thinkpadp1gen7.raanaii.csb> Signed-off-by: utruong309 <uyenthutruong09@gmail.com>
utruong309
pushed a commit
to utruong309/notebooks
that referenced
this pull request
Jan 8, 2026
* chore: Update Go module paths from kubeflow/kubeflow to kubeflow/notebooks - Updated module declarations in 3 go.mod files (notebook-controller, tensorboard-controller, pvcviewer-controller) - Updated all internal import statements in Go source files to match new module paths - Updated reconcilehelper imports to use local paths (after PR kubeflow#702 moved reconcilehelper into each controller) - Verified all components compile successfully Fixes kubeflow#699 Signed-off-by: Asaad Balum <asaad.balum@gmail.com> * chore: Update PROJECT files to use kubeflow/notebooks paths - Updated all repo and API paths in PROJECT files - Changed pvcviewer projectName from 'pvc-viewer' to 'pvcviewer-controller' Addresses feedback from review Signed-off-by: Asaad Balum <asaad.balum@gmail.com> * mathew: fix rename of `pvc-viewer` path Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> --------- Signed-off-by: Asaad Balum <asaad.balum@gmail.com> Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Signed-off-by: utruong309 <uyenthutruong09@gmail.com>
utruong309
pushed a commit
to utruong309/notebooks
that referenced
this pull request
Jan 8, 2026
- Delete common component (OWNERS, go.mod, reconcilehelper/) - Copy reconcilehelper/util.go to both notebook-controller and tensorboard-controller - Update imports in both controllers to use local reconcilehelper - Remove common dependency from go.mod files - Update Dockerfiles to remove common component references Signed-off-by: Yehudit Kerido <ykerido@ykerido-thinkpadp1gen7.raanaii.csb> Co-authored-by: Yehudit Kerido <ykerido@ykerido-thinkpadp1gen7.raanaii.csb> Signed-off-by: utruong309 <uyenthutruong09@gmail.com>
utruong309
pushed a commit
to utruong309/notebooks
that referenced
this pull request
Jan 8, 2026
* chore: Update Go module paths from kubeflow/kubeflow to kubeflow/notebooks - Updated module declarations in 3 go.mod files (notebook-controller, tensorboard-controller, pvcviewer-controller) - Updated all internal import statements in Go source files to match new module paths - Updated reconcilehelper imports to use local paths (after PR kubeflow#702 moved reconcilehelper into each controller) - Verified all components compile successfully Fixes kubeflow#699 Signed-off-by: Asaad Balum <asaad.balum@gmail.com> * chore: Update PROJECT files to use kubeflow/notebooks paths - Updated all repo and API paths in PROJECT files - Changed pvcviewer projectName from 'pvc-viewer' to 'pvcviewer-controller' Addresses feedback from review Signed-off-by: Asaad Balum <asaad.balum@gmail.com> * mathew: fix rename of `pvc-viewer` path Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> --------- Signed-off-by: Asaad Balum <asaad.balum@gmail.com> Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Signed-off-by: utruong309 <uyenthutruong09@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #700