feat: enable kueue integration by ensuing that labels added to Notebooks are propogated to the underlying StatefulSet#788
Open
kannon92 wants to merge 1 commit intokubeflow:notebooks-v1from
Conversation
google-oss-prow
bot
added
the
area/controller
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
kannon92
changed the title
3 tasks
kannon92
force-pushed
the
propogate-notebook-labels-kueue-integration
branch
from
62f2472 to
5b77921
Compare
1 task
jiridanek
reviewed
Dec 8, 2025
components/notebook-controller/controllers/notebook_controller_bdd_test.go
Show resolved
Hide resolved
kannon92
force-pushed
the
propogate-notebook-labels-kueue-integration
branch
from
e1d2a72 to
c2f5760
Compare
Member
|
Thank you @kannon92, looking forward to integrate Notebooks and Kueue! /assign @kubeflow/wg-notebooks-leads @andyatmiami @ederign |
…e propogated to the underlying StatefulSet Signed-off-by: Kevin Hannon <kehannon@redhat.com>
kannon92
force-pushed
the
propogate-notebook-labels-kueue-integration
branch
from
c2f5760 to
4da8e98
Compare
Author
|
Any thoughts on this? |
Author
|
Ping @kubeflow/wg-notebooks-leads |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply stale kubeflow/kubeflow#7674 to this v1 branch.
This was a clean pick of opendatahub-io/kubeflow#646.
It looks like this was merged in opendatahub but I didn't see this patch contributed to kubeflow notebooks.
This should provide integration with Kueue based on kubernetes-sigs/kueue#3878 (comment).