Skip to content

feat: Setup the WorspaceKind samples in Tilt#924

Draft
christian-heusel wants to merge 1 commit intokubeflow:notebooks-v2from
christian-heusel:feat/add-wsk-samples-tilt
Draft

feat: Setup the WorspaceKind samples in Tilt#924
christian-heusel wants to merge 1 commit intokubeflow:notebooks-v2from
christian-heusel:feat/add-wsk-samples-tilt

Conversation

@christian-heusel
Copy link

This leads to a more streamlined development experience that shows more of the new features and allows developers to have a good default experience when working on new features.

Related to #906

This leads to a more streamlined development experience that shows more
of the new features and allows developers to have a good default
experience when working on new features.

Related to kubeflow#906

Signed-off-by: Christian Heusel <christian@heusel.eu>
@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Feb 21, 2026
@google-oss-prow google-oss-prow bot added the area/ci area - related to ci label Feb 21, 2026
@google-oss-prow google-oss-prow bot added the area/v2 area - version - kubeflow notebooks v2 label Feb 21, 2026
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andyatmiami for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christian-heusel
Copy link
Author

/ok-to-test

@christian-heusel
Copy link
Author

Drafting this after a discussion on Slack (https://cloud-native.slack.com/archives/C073W562HFY/p1771847252538599 for reference), we'll need to invest some more work in order to ensure that make tilt-down behaves smoothly with this, otherwise users will be stuck with:

uncategorized │ Initial Build
uncategorized │ STEP 1/1 — Deploying
uncategorized │      Applying YAML to cluster
uncategorized │      Resource workspacekinds.kubeflow.org is currently being deleted. Waiting 1m for deletion before retrying...

The end goal would be to

  • only apply workspace kinds (not the sample workspace)
  • have a one-off script integrated in the makefile target tilt-up that creates the needed WSKs in order to externalize this from tilt (and the samples do not benefit from the hot reloading etc. that tilt provides anyways)

@christian-heusel
Copy link
Author

We concluded to take https://github.com/external-secrets/external-secrets/blob/main/Tiltfile as inspiration 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci area - related to ci area/v2 area - version - kubeflow notebooks v2 do-not-merge/work-in-progress ok-to-test size/XS

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

1 participant