fix: replace bare except with except Exception in KFP client#13083
fix: replace bare except with except Exception in KFP client#13083harshadkhetpal wants to merge 1 commit intokubeflow:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @harshadkhetpal. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Pull request overview
This pull request fixes exception handling in the KFP client's _load_config method by replacing bare except: clauses with except Exception:. Bare except clauses inadvertently catch all BaseExceptions including KeyboardInterrupt and SystemExit, which should propagate normally to allow users to interrupt the application. The fix ensures proper signal handling while maintaining the same fallback behavior for normal exceptions during Kubernetes configuration loading.
Changes:
- Replace two bare
except:clauses withexcept Exception:in the_load_configmethod (lines 305 and 316) - Allows KeyboardInterrupt and SystemExit to propagate correctly while still catching normal configuration loading exceptions
Summary
Replace two bare
except:clauses withexcept Exception:insdk/python/kfp/client/client.py.Changes (lines 305 and 316):
Bare
except:catches BaseException including KeyboardInterrupt and SystemExit. These two blocks are config-loading fallbacks that should only handle normal exceptions. Usingexcept Exception:is the correct scope.Testing
No behavior change for normal exception paths. Ctrl-C signals now propagate correctly instead of being silently swallowed.