Skip to content

fix: replace bare except with except Exception in KFP client#13083

Open
harshadkhetpal wants to merge 1 commit intokubeflow:masterfrom
harshadkhetpal:fix/bare-except-kfp-client
Open

fix: replace bare except with except Exception in KFP client#13083
harshadkhetpal wants to merge 1 commit intokubeflow:masterfrom
harshadkhetpal:fix/bare-except-kfp-client

Conversation

@harshadkhetpal
Copy link

Summary

Replace two bare except: clauses with except Exception: in sdk/python/kfp/client/client.py.

Changes (lines 305 and 316):

# Before
except:
    in_cluster = False

# After
except Exception:
    in_cluster = False

Bare except: catches BaseException including KeyboardInterrupt and SystemExit. These two blocks are config-loading fallbacks that should only handle normal exceptions. Using except Exception: is the correct scope.

Testing

No behavior change for normal exception paths. Ctrl-C signals now propagate correctly instead of being silently swallowed.

Copilot AI review requested due to automatic review settings March 19, 2026 18:42
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

Hi @harshadkhetpal. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes exception handling in the KFP client's _load_config method by replacing bare except: clauses with except Exception:. Bare except clauses inadvertently catch all BaseExceptions including KeyboardInterrupt and SystemExit, which should propagate normally to allow users to interrupt the application. The fix ensures proper signal handling while maintaining the same fallback behavior for normal exceptions during Kubernetes configuration loading.

Changes:

  • Replace two bare except: clauses with except Exception: in the _load_config method (lines 305 and 316)
  • Allows KeyboardInterrupt and SystemExit to propagate correctly while still catching normal configuration loading exceptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants