Skip to content

fix: replace bare except: with except Exception: in SDK #13084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshadkhetpal wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −4
Open

fix: replace bare except: with except Exception: in SDK #13084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d561259
fix: replace bare `except:` with `except Exception:` in v1_modelbase.py
harshadkhetpal Mar 19, 2026
8bd77cd
fix: replace bare `except:` with `except Exception:` in client.py
harshadkhetpal Mar 19, 2026
68c2402
fix: replace bare `except:` with `except Exception:` in type_utils.py
harshadkhetpal Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/python/kfp/client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ def _load_config(
in_cluster = True
try:
k8s.config.load_incluster_config()
except:
except Exception:
in_cluster = False

if in_cluster:
Expand All @@ -313,7 +313,7 @@ def _load_config(
try:
k8s.config.load_kube_config(
client_configuration=config, context=kube_context)
except:
except Exception:
print('Failed to load kube config.')
return config

Expand Down
2 changes: 1 addition & 1 deletion sdk/python/kfp/dsl/types/type_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def bool_cast_fn(default: Union[str, bool]) -> bool:
def try_loading_json(default: str) -> Union[dict, list, str]:
try:
return json.loads(default)
except:
except Exception:
return default


Expand Down
2 changes: 1 addition & 1 deletion sdk/python/kfp/dsl/v1_modelbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def parse_object_from_struct_based_on_type(struct: Any, typ: Type[T]) -> T:
#):
if type(struct) is typ:
return struct
except:
except Exception:
pass
if hasattr(typ, 'from_dict'):
try: #More informative errors
Expand Down
Loading