chore: upgrade golangci-lint to version 2 #969
Conversation
k8s-ci-robot
added
release-note-none
|
Hi @retornam. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: retornam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
ok-to-test
retornam
force-pushed
the
retornam/edits
branch
from
5f4e391 to
73a906e
Compare
|
/retest |
retornam
force-pushed
the
retornam/edits
branch
from
73a906e to
11d67e1
Compare
Pull Request Test Coverage Report for Build 17217515710Details
💛 - Coveralls |
retornam
force-pushed
the
retornam/edits
branch
from
11d67e1 to
082b447
Compare
|
/retest |
|
@retornam: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project from Go version 1.24 to 1.25 and updates golangci-lint configuration to version 2, along with code quality improvements and formatting fixes.
- Updates Go version from 1.24 to 1.25 across all GitHub workflow files
- Upgrades golangci-lint from v1.64 to v2.4.0 with new configuration format
- Applies various code formatting and style improvements identified by the updated linter
Reviewed Changes
Copilot reviewed 36 out of 39 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates Go version from 1.24 to 1.25 |
| .golangci.yml | Upgrades golangci-lint configuration to version 2 format |
| .github/workflows/*.yaml | Updates Go versions in CI workflows from older versions to 1.25 |
| pkg/smb/*.go | Fixes octal literals, variable declarations, error messages, and imports formatting |
| test/e2e/*.go | Improves import formatting and API usage patterns |
| release-tools/filter-junit.go | Updates file permissions to use octal literal format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -47,7 +47,7 @@ func Mount(m *mount.SafeFormatAndMount, source, target, fsType string, options, | |||
| }() | |||
|
|
|||
| for _, option := range sensitiveMountOptions { | |||
| if _, err := file.Write([]byte(fmt.Sprintf("%s\n", option))); err != nil { | |||
| if _, err := fmt.Fprintf(file, "%s\n", option); err != nil { | |||
There was a problem hiding this comment.
not sure whether it's an identical change, is this part of golint change? it seems not
There was a problem hiding this comment.
it is. I'll revert if you prefer the earlier version and add an ignore.
Upgrade Golang to version to 1.25
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
It upgrades Golang version to 1.25 and golangci-lint to version 2
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: