-
Notifications
You must be signed in to change notification settings - Fork 35
Suffixing '/v3' to module name to conform go modules' convention #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: everpeace The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @everpeace! |
Hi @everpeace. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
+1, currently the latest release (v3) is unusable from within Go applications (though Go modules). |
/ok-to-test |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently
lib-volume-populator
module does not follow Go module's major version convention. This fixes it so as to follow the convention.ref: https://go.dev/doc/modules/version-numbers#major-version
Which issue(s) this PR fixes:
fixed #224
Special notes for your reviewer:
Does this PR introduce a user-facing change?: