Adding IOPS Increase On Resize If iopspergb & allowautoiopsincreaseonresize are set #2635
+213
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
|
/hold Unit tests need to be added after initial rev is reviewed. |
k8s-ci-robot
added
the
do-not-merge/hold
mdzraf
force-pushed
the
allowIopsIncreaseOnResize
branch
from
e825560 to
f18c9a7
Compare
mdzraf
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
mdzraf
force-pushed
the
allowIopsIncreaseOnResize
branch
4 times, most recently
from
d46dd5a to
5bfc434
Compare
Code Coverage Diff
|
mdzraf
force-pushed
the
allowIopsIncreaseOnResize
branch
from
5bfc434 to
93ead5c
Compare
mdzraf
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
ConnorJC3
requested changes
Aug 27, 2025
mdzraf
force-pushed
the
allowIopsIncreaseOnResize
branch
from
93ead5c to
28ee283
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ConnorJC3
reviewed
Sep 16, 2025
| } else { | ||
| req.Iops = aws.Int32(capIOPS(string(volTypeToUse), sizeToUse, iopsValue, IopLimits, false)) | ||
| } | ||
| options.IOPS = *req.Iops |
There was a problem hiding this comment.
Would it make the code saner if we passed req into validateModifyVolume instead of options?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What is this PR about? / Why do we need it?
This PR adds a way for allowing IOPS to be increased if a volume is resized and
IopsPerGBis set. This way the ratio will remain as expected after a resize, in order to use this featureallowautoiopsincreaseonresizemust be set to true as well.This PR also adds
iopspergbas a VAC parameter so that it can be changed.How was this change tested?
As of this first revision, no unit tests have been added
or existing ones have been modified, manual testing listed below. Unit tests will be a part of revision 2 after initial rev is reviewedManual Tests Performed:
iopspergbratio and ensuring IOPS are adjusted correctly to new size and ratio ✅iopspergbset butallowautoiopsincreaseonresizenot set/set to false, ensure that resize happens but no IOPS are adjusted ✅iopspergbis increased and IOPS are adjusted accordingly depending on volume size ✅allowautoiopsincreaseonresizeis set to true after initial volume creation, and then resizes. IOPS are adjusted accordingly ✅Does this PR introduce a user-facing change?