-
Notifications
You must be signed in to change notification settings - Fork 849
Add encryption support ext4 format option to StorageClass params #2820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add encryption support ext4 format option to StorageClass params #2820
Conversation
Code Coverage DiffThis PR does not change the code coverage |
1aac2d5 to
b406fc7
Compare
b406fc7 to
58da2dd
Compare
torredil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
mdzraf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm (besides Eddie's comment being addressed)
58da2dd to
e034250
Compare
ElijahQuinones
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
mdzraf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
torredil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Signed-off-by: Connor Catlett <[email protected]>
e034250 to
57d45ad
Compare
|
/lgtm |
mdzraf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdzraf, torredil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What is this PR about? / Why do we need it?
Fixes #2394, allowing encryption of data at rest via non-EBS encryption methods.
How was this change tested?
Added CI and unit tests.
Does this PR introduce a user-facing change?