Skip to content

Conversation

@ConnorJC3
Copy link
Contributor

@ConnorJC3 ConnorJC3 commented Jan 6, 2026

What type of PR is this?

/kind feature

What is this PR about? / Why do we need it?

Fixes #2394, allowing encryption of data at rest via non-EBS encryption methods.

How was this change tested?

Added CI and unit tests.

Does this PR introduce a user-facing change?

Add new StorageClass parameter `ext4EncryptionSupport` to enable encryption support in ext4 for non-EBS encryption at rest

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 6, 2026
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Code Coverage Diff

This PR does not change the code coverage

@ConnorJC3 ConnorJC3 force-pushed the encrypt-format-option branch from 1aac2d5 to b406fc7 Compare January 6, 2026 20:35
@ConnorJC3 ConnorJC3 changed the title WIP: Add ext4 format option to StorageClass params Add encryption support ext4 format option to StorageClass params Jan 6, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2026
@ConnorJC3 ConnorJC3 force-pushed the encrypt-format-option branch from b406fc7 to 58da2dd Compare January 6, 2026 20:48
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2026
Copy link
Member

@mdzraf mdzraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm (besides Eddie's comment being addressed)

@ConnorJC3 ConnorJC3 force-pushed the encrypt-format-option branch from 58da2dd to e034250 Compare January 7, 2026 18:28
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2026
Copy link
Member

@ElijahQuinones ElijahQuinones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2026
Copy link
Member

@mdzraf mdzraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2026
@ConnorJC3 ConnorJC3 force-pushed the encrypt-format-option branch from e034250 to 57d45ad Compare January 7, 2026 19:07
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2026
@torredil
Copy link
Member

torredil commented Jan 7, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2026
Copy link
Member

@mdzraf mdzraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdzraf, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit dd1e895 into kubernetes-sigs:master Jan 7, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Expose -O encrypt format option

5 participants