✨ Allow accepting self-hosted gitlab installations#706
✨ Allow accepting self-hosted gitlab installations#706k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
|
Hi @ts-mini. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aef8fda to
9f3099d
Compare
c29d9f1 to
90d55ab
Compare
90d55ab to
63b6f1f
Compare
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 35686f6620c4a71138cf90e1bca9dc5b953d95da |
|
/retitle ✨ Allow accepting self-hosted gitlab installations |
What this PR does / why we need it: The current implementation of the gitlab check uses HasPrefix - which doesn't allow for a gitlab whose domain could be different (gitlab-example.domain.com)
Which issue(s) this PR fixes:
Fixes #705