🌱 Add new Makefile target to run e2e tests locally#715
🌱 Add new Makefile target to run e2e tests locally#715k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
|
Hi @dmvolod. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@dmvolod thanks for the PR, can we also document it similar to https://github.com/kubernetes-sigs/cluster-api/blob/f3e3bda15c62f6cecb235c943f4ff337ce4ab5d1/docs/book/src/developer/testing.md?plain=1#L178C1-L180 in https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/test/e2e/README.md maybe? |
|
/ok-to-test |
Good point, @furkatgofurov7, thank you. |
furkatgofurov7
left a comment
There was a problem hiding this comment.
Thanks!
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 444b9aa33aa48c793f19496a17b082742e42ccf4 |
What this PR does / why we need it:
This PR introduces new Makefile target with
docker-build-e2eprerequisite targetWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #141