Skip to content

Conversation

@xtineskim
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Adding the Cilium conformance test for 1.4!

Which issue(s) this PR fixes:
n/a

Fixes #
n/a

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 7, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 7, 2025
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xtineskim! Feel free to remove the hold if you want to cover the update to implementations list in a separate PR.

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2025
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 7, 2025
@xtineskim xtineskim force-pushed the cilium-1.4-conformance-report branch from c3cfb1c to 4b7a5f0 Compare November 10, 2025 20:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, xtineskim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@youngnick
Copy link
Contributor

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit b4aa664 into kubernetes-sigs:main Nov 10, 2025
20 checks passed
@xtineskim xtineskim deleted the cilium-1.4-conformance-report branch November 10, 2025 22:47
youngnick added a commit to youngnick/gateway-api that referenced this pull request Nov 10, 2025
Now that kubernetes-sigs#4233 merged.

Signed-off-by: Nick Young <[email protected]>
youngnick added a commit to youngnick/gateway-api that referenced this pull request Nov 10, 2025
Now that kubernetes-sigs#4233 merged.

Signed-off-by: Nick Young <[email protected]>
@tisonkun
Copy link

May you take a look at #4225 so that we can avoid code diff back and forth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants