Controller matching wizard - #4584
Conversation
|
🔥 🌟 nits/nice to have (non blocker)
|
| # Feature definitions for the wizard: id and label match v1.4 conformance table columns | ||
| # https://gateway-api.sigs.k8s.io/implementations/v1.4/ | ||
| FEATURE_DEFINITIONS = { | ||
| "httpGateway": [ |
There was a problem hiding this comment.
more of a todo: will be worth getting the ids and labels generated rather than hard coded
There was a problem hiding this comment.
Idk exactly how to do it. Feature names are not as descriptive in reports, so hard coded for later parsing.
Feel free to propose something
There was a problem hiding this comment.
might be able to just get the label from the id, adding a space between the words. But this is not a blocker, so can be done in a later pr 👍
Co-authored-by: Rob Scott <rob.scott87@gmail.com>
|
robscott
left a comment
There was a problem hiding this comment.
Thanks @bexxmodd, deploy preview looks great! Will defer to someone else for final LGTM.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bexxmodd, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Yeah, I think this looks great. /lgtm |
* Add script to verify release artifacts. * Add \n * Add data extraction script and html for wizard. * Remove extra file. * Added wizard content. * Added hook to wizard data generation. * Removed redundant data json. * Convert wizard into an wasm app. * Remove data json file. * Exclude wasm from linter. * Limit versions to the latest three and rename Want to have -> Must have * Update site-src/wizard/controller-wizard.html Co-authored-by: Rob Scott <rob.scott87@gmail.com> * host wizard on k8s page. * Changed header and wording and update linter run to exclude wasm folder. * css adjustments to fit mkdocs. * typo for border. * Trying to pass golinter. * removed misplaced build directive. * Add boilerplate to go files. * Make adjustments to the wizard: added descriptions, subheadings, renamed recommend to match. * Go lint update. * Improve embedding of wizard into mkdocs. * css adjustments. * move feature groups around. * reset grpcecho.pd.go * space * Another space * Added random tiebreaker. * Replace math/rand with math/rand/v2 * Updated UI to improve UX. * changed wording of intro paragraph. * Prevent nested scroll bar from appearing. * Nest backendTLS in HTTPRoute. * update to ui. extended features only appear of the resource is selected. * updated wording. * fixed go linter errors. * replace specific version selection with minimum version selection. * remove note section. * extra white line between intro paragraph and selection. --------- Co-authored-by: Rob Scott <rob.scott87@gmail.com>
What type of PR is this?
/kind documentation
What this PR does / why we need it:
It's a controller matching wizard for the providers that submitted conformance reports. This should simplify operator/controller selection compared to peeking at the table's features.
You can run this by and test it locally at (http://localhost:8080/index.html):
Probably many things will require adjustment before this can be hosted, but it's good enough to try it locally for the initial feedback.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: