Skip to content

Conversation

shwetha-s-poojary
Copy link

@shwetha-s-poojary shwetha-s-poojary commented Sep 9, 2025

Changes:

  1. Bumped base image from Debian Bullseye to Bookworm

  2. Fixed dpkg-query failure due to path mismatch
    Root cause: The build script uses which bash, resolving to /usr/bin/bash. On systems with merged /usr layout, this path is valid, but dpkg-query only matches exact paths recorded in the package database—typically /bin/bash. (mismatch occurs because dpkg-query doesn’t follow symlinks or filesystem structure; it relies solely on the original install path recorded by the package)
    Fix: Used wildcard match — dpkg-query -S '*/bin/bash'

Testing:

  • Image built successfully using Podman
  • Image built via make quick
  • Validated on a multi-node KIND cluster with all nodes operational

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shwetha-s-poojary
Once this PR has been reviewed and has the lgtm label, please assign bentheelder for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @shwetha-s-poojary!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 9, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @shwetha-s-poojary. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 9, 2025
@shwetha-s-poojary
Copy link
Author

/retitle Bump image from bullseye to bookworm for local-path-helper

@k8s-ci-robot
Copy link
Contributor

@shwetha-s-poojary: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle Bump image from bullseye to bookworm for local-path-helper

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shwetha-s-poojary shwetha-s-poojary changed the title Bump image from bullseye to bookworm Bump image from bullseye to bookworm for local-path-helper Sep 9, 2025
@aojea
Copy link
Contributor

aojea commented Sep 9, 2025

last time we had some issues with the bump so you should build the image and test it works

@BenTheElder
Copy link
Member

last time we had some issues with the bump so you should build the image and test it works

yeah, this one may be more involved (but necessary at some point!)

recalling now #3350 ...

dpkg-query --search "$(realpath "${1}")" | cut -d':' -f1
# Match bash path in dpkg regardless of /usr merge
dpkg-query --search "$(realpath "${1}" | sed 's|/usr|*|')" | cut -d':' -f1
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced /usr/bin/bash with a wildcard match (*/bin/bash) in dpkg-query to handle systems with merged /usr layout. This ensures compatibility where bash is symlinked to /usr/bin/bash, but only /bin/bash is recorded in the package database

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of sed, we can realpath the output path?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

realpath resolves to /usr/bin/bash on merged /usr systems, but dpkg-query only matches /bin/bash in the package database. The sed wildcard workaround does work for these cases, though I’m exploring whether there’s a more canonical or robust way to handle this mismatch. I’d appreciate any suggestions you might have.

@shwetha-s-poojary shwetha-s-poojary marked this pull request as ready for review September 22, 2025 08:21
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2025
@shwetha-s-poojary shwetha-s-poojary changed the title Bump image from bullseye to bookworm for local-path-helper Bump image from bullseye to bookworm for local-path-helper, local-path-provisioner Sep 22, 2025
@shwetha-s-poojary
Copy link
Author

Hey @BenTheElder

I've built the local-path-provisioner and helper and the kindnetd image using the debian12 base image. I had used them in a node image that pointed to the same and things work as expected in my amd64 test environment.
Please let me know if we should be good to merge these changes or if you have any other concerns, will be happy to address.

Thanks,
Shwetha

@stmcginnis
Copy link
Contributor

Change makes sense to me. Built image locally and everything appears to be find.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 30, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants