-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Bump image from bullseye to bookworm for local-path-helper, local-path-provisioner #4003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bump image from bullseye to bookworm for local-path-helper, local-path-provisioner #4003
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shwetha-s-poojary The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @shwetha-s-poojary! |
Hi @shwetha-s-poojary. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retitle Bump image from bullseye to bookworm for local-path-helper |
@shwetha-s-poojary: Re-titling can only be requested by trusted users, like repository collaborators. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
last time we had some issues with the bump so you should build the image and test it works |
yeah, this one may be more involved (but necessary at some point!) recalling now #3350 ... |
68fdc8e
to
4ca9a0d
Compare
dpkg-query --search "$(realpath "${1}")" | cut -d':' -f1 | ||
# Match bash path in dpkg regardless of /usr merge | ||
dpkg-query --search "$(realpath "${1}" | sed 's|/usr|*|')" | cut -d':' -f1 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced /usr/bin/bash with a wildcard match (*/bin/bash) in dpkg-query to handle systems with merged /usr layout. This ensures compatibility where bash is symlinked to /usr/bin/bash, but only /bin/bash is recorded in the package database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of sed, we can realpath the output path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
realpath resolves to /usr/bin/bash on merged /usr systems, but dpkg-query only matches /bin/bash in the package database. The sed wildcard workaround does work for these cases, though I’m exploring whether there’s a more canonical or robust way to handle this mismatch. I’d appreciate any suggestions you might have.
4ca9a0d
to
fc0e59f
Compare
fc0e59f
to
2ee2693
Compare
Hey @BenTheElder I've built the local-path-provisioner and helper and the kindnetd image using the debian12 base image. I had used them in a node image that pointed to the same and things work as expected in my amd64 test environment. Thanks, |
Change makes sense to me. Built image locally and everything appears to be find. /ok-to-test |
Changes:
Bumped base image from Debian Bullseye to Bookworm
Fixed dpkg-query failure due to path mismatch
Root cause: The build script uses
which bash
, resolving to /usr/bin/bash. On systems with merged /usr layout, this path is valid, but dpkg-query only matches exact paths recorded in the package database—typically /bin/bash. (mismatch occurs because dpkg-query doesn’t follow symlinks or filesystem structure; it relies solely on the original install path recorded by the package)Fix: Used wildcard match —
dpkg-query -S '*/bin/bash'
Testing: