-
Notifications
You must be signed in to change notification settings - Fork 1.7k
doc: runtimeConfig can be used to enable deprecated APIs #4009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @kalexmills! |
Hi @kalexmills. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Seems like a nice breadcrumb to include for someone looking for how to do this. /ok-to-test |
/assign @BenTheElder |
/test |
@kalexmills: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Looks to me like all this is waiting for is approval. Sorry for the comment spam. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks!
we may also have to update these docs soon for kubernetes/kubernetes#133697
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, kalexmills The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes #1271.
This PR documents how to enable deprecated APIs via
runtimeConfig
.This ticket is a bit old, so I tested that this still works via kind v0.27.0, running images for k8s v1.29.14.
After creating the cluster I can see the
ValidatingAdmissionPolicy
is enabled at v1alpha1. In k8s v1.29, the v1alpha1 version of this resource was deprecated in favor of v1beta1 (link).Creating a cluster without the
runtimeConfig
above results in noValidatingAdmissionPolicies
being shown.