Skip to content

Fail fast for empty kubebuilder assets#10059

Open
PannagaRao wants to merge 1 commit intokubernetes-sigs:mainfrom
PannagaRao:guard-empty-kubebuilder_assets
Open

Fail fast for empty kubebuilder assets#10059
PannagaRao wants to merge 1 commit intokubernetes-sigs:mainfrom
PannagaRao:guard-empty-kubebuilder_assets

Conversation

@PannagaRao
Copy link
Contributor

@PannagaRao PannagaRao commented Mar 20, 2026

Signed-off-by: Pannaga Rao Bhoja Ramamanohara

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

Fail fast when setup-envtest fails to download binaries instead of running all test suites only to fail in BeforeSuite with etcd not found in $PATH

Which issue(s) this PR fixes:

Fixes # #9821

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Pannaga Rao Bhoja Ramamanohara
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 20, 2026
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 20, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @PannagaRao. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PannagaRao
Once this PR has been reviewed and has the lgtm label, please assign gabesaba, mbobrovskyi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 20, 2026
@netlify
Copy link

netlify bot commented Mar 20, 2026

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit e2b562c
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/69bdb86eebb1e600081d6a3d
😎 Deploy Preview https://deploy-preview-10059--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mimowo
Copy link
Contributor

mimowo commented Mar 20, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants