bug: IsExplicitlyRequestingTAS ignores PodsetSliceRequiredTopologyConstraints#10063
Open
Huang-Wei wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
bug: IsExplicitlyRequestingTAS ignores PodsetSliceRequiredTopologyConstraints#10063Huang-Wei wants to merge 1 commit intokubernetes-sigs:mainfrom
Huang-Wei wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
…straints When only podset-slice-required-topology-constraints annotation is set, IsExplicitlyRequestingTAS returns false, causing multi-layer topology requests to be silently ignored in non-TAS-only ClusterQueues.
k8s-ci-robot
added
release-note-none
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Huang-Wei The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/area tas
What this PR does / why we need it:
When only
podset-slice-required-topology-constraintsannotation is set,IsExplicitlyRequestingTAS()returns false, and hence multi-layer topology request will be silently ignored in non-TAS-only ClusterQueues.In reality this is a corner case b/c we usually set the top-level
podset-required-topologyto "datacenter" or other topology, which evaluatesIsExplicitlyRequestingTAS()to true. But we'd better not make that assumption.Which issue(s) this PR fixes:
Part of #9046
Special notes for your reviewer:
Does this PR introduce a user-facing change?