docs: clarify deprecation status and future removal of the `--visibil…#10074
Conversation
…ity-server-port` flag.
|
Hi @Nilsachy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @mimowo |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/ok-to-test |
site/content/en/docs/tasks/manage/monitor_pending_workloads/pending_workloads_on_demand.md
Outdated
Show resolved
Hide resolved
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 3b6ee023444a169a0efe490af9425049b315899c |
|
/hold The release note seems broken, copied from a different PR I guess. I'd expect it to be empty. |
|
Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/unhold @Nilsachy the release note is still broken. It has to be wrapped like this: ```release-note |
Oh sorry that's right. Editted. |
|
/remove-kind deprecation |
|
/release-note-none |
|
/lgtm The description release note still looks a bit malformed (NONE is written twice), but probably not an issue in practice since you labeled it manually. |
|
LGTM label has been added. DetailsGit tree hash: 33bc678da9ca75e7750d8c4084460c75815e9e41 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, Nilsachy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Update the doc to deprecate
visibility-server-portin 0.17.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
NONE