Skip to content

docs: clarify deprecation status and future removal of the `--visibil…#10074

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
Nilsachy:update-documentation-to-deprecate-visibility-server-flag
Mar 24, 2026
Merged

docs: clarify deprecation status and future removal of the `--visibil…#10074
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
Nilsachy:update-documentation-to-deprecate-visibility-server-flag

Conversation

@Nilsachy
Copy link
Contributor

@Nilsachy Nilsachy commented Mar 23, 2026

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Update the doc to deprecate visibility-server-port in 0.17.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?

NONE

NONE

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 23, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @Nilsachy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2026
@Nilsachy
Copy link
Contributor Author

/assign @mimowo

@Nilsachy Nilsachy marked this pull request as ready for review March 23, 2026 17:52
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2026
@netlify
Copy link

netlify bot commented Mar 23, 2026

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit cb6f217
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/69c259a0ac44260008cabc50
😎 Deploy Preview https://deploy-preview-10074--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot requested a review from tenzen-y March 23, 2026 17:52
@mimowo
Copy link
Contributor

mimowo commented Mar 23, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 23, 2026
@kshalot
Copy link
Contributor

kshalot commented Mar 24, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2026
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 3b6ee023444a169a0efe490af9425049b315899c

@kshalot
Copy link
Contributor

kshalot commented Mar 24, 2026

/hold

The release note seems broken, copied from a different PR I guess. I'd expect it to be empty.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2026
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 24, 2026
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2026
@k8s-ci-robot k8s-ci-robot requested review from kshalot and mimowo March 24, 2026 09:30
@kshalot
Copy link
Contributor

kshalot commented Mar 24, 2026

/unhold

@Nilsachy the release note is still broken. It has to be wrapped like this:

```release-note
NONE
```

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2026
@Nilsachy
Copy link
Contributor Author

/unhold

@Nilsachy the release note is still broken. It has to be wrapped like this:

release-note NONE

Oh sorry that's right. Editted.

@Nilsachy
Copy link
Contributor Author

/remove-kind deprecation

@k8s-ci-robot k8s-ci-robot removed the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Mar 24, 2026
@Nilsachy
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 24, 2026
@kshalot
Copy link
Contributor

kshalot commented Mar 24, 2026

/lgtm

The description release note still looks a bit malformed (NONE is written twice), but probably not an issue in practice since you labeled it manually.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2026
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 33bc678da9ca75e7750d8c4084460c75815e9e41

@mimowo
Copy link
Contributor

mimowo commented Mar 24, 2026

/approve
thank you!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, Nilsachy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2026
@k8s-ci-robot k8s-ci-robot merged commit 816af5a into kubernetes-sigs:main Mar 24, 2026
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.17 milestone Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants