Add Helm values to disable KueueViz ingress resources#8986
Conversation
Add kueueViz.backend.ingress.enabled and kueueViz.frontend.ingress.enabled options to allow users to disable ingress creation.
k8s-ci-robot
added
the
release-note
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @david-gang. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
size/M
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
mimowo
left a comment
mimowo
left a comment
There was a problem hiding this comment.
Thank you 👍
/lgtm
/approve
/cherrypick release-0.16
/cherrypick release-0.15
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: afca6d50d2b5c1902d33a01df502bc1a962a120c |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: david-gang, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/kind feature |
k8s-ci-robot
added
the
kind/feature
…s#8986) Add kueueViz.backend.ingress.enabled and kueueViz.frontend.ingress.enabled options to allow users to disable ingress creation.
…s#8986) Add kueueViz.backend.ingress.enabled and kueueViz.frontend.ingress.enabled options to allow users to disable ingress creation.
|
/cherrypick release-0.16 |
|
@tenzen-y: new pull request created: #10064 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/release-note-edit |
|
@tenzen-y: new pull request created: #10065 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add
kueueViz.backend.ingress.enabledandkueueViz.frontend.ingress.enabledHelm values to allow users to disable ingress creation when using alternative ingress solutions (e.g., IstioGateway/VirtualService).
Both options default to
truefor backwards compatibility.Which issue(s) this PR fixes:
Fixes #7659
Special notes for your reviewer:
The change is implemented via the yaml-processor in
hack/processing-plan.yaml. Helm unit tests have been added to verify the behavior.Does this PR introduce a user-facing change?