Skip to content

[integration] Drop ginkgo.Ordered from singlecluster tests to enable parallelism#9972

Open
Paramesh324 wants to merge 2 commits intokubernetes-sigs:mainfrom
Paramesh324:eliminate_ginkgo_ordered
Open

[integration] Drop ginkgo.Ordered from singlecluster tests to enable parallelism#9972
Paramesh324 wants to merge 2 commits intokubernetes-sigs:mainfrom
Paramesh324:eliminate_ginkgo_ordered

Conversation

@Paramesh324
Copy link

What type of PR is this?

/kind cleanup
/area testing

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #9880

Special notes for your reviewer:

Removes ginkgo.Ordered from all suites under test/integration/singlecluster, so specs can run in arbitrary order and parallel worker. Dropping Ordered allows ginkgo to randomize and parallelize these specs.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/testing Testing - related stuff labels Mar 18, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Paramesh324
Once this PR has been reviewed and has the lgtm label, please assign pbundyra for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Mar 18, 2026

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 6ba1d7b
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/69bcfa09e443f0000896d188

@k8s-ci-robot k8s-ci-robot requested review from mimowo and tenzen-y March 18, 2026 09:06
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2026
@k8s-ci-robot
Copy link
Contributor

Welcome @Paramesh324!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 18, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @Paramesh324. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 18, 2026
@mimowo
Copy link
Contributor

mimowo commented Mar 18, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2026
var _ = ginkgo.Describe("AdmissionCheck controller", ginkgo.Label("controller:admissioncheck", "area:core"), func() {
var ns *corev1.Namespace

ginkgo.BeforeAll(func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BeforeAll() not working without ginkgo.Ordered.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question from my end, do we need to add ginkgo.Ordered back on all the Describe/When/Context blocks that use BeforeAll() or only in this particular file would be sufficient.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this logic to BeforeEach()?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the BeforeAll() issue, should we move manager setup to BeforeEach() once across all singlecluster intergration tests that use BeforeAll()?

Copy link
Contributor

@mbobrovskyi mbobrovskyi Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an example what we need: #8726.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 18, 2026
…parallelism

Signed-off-by: Parameshwaran Krishnasamy <Parameshwaran.K@ibm.com>
Signed-off-by: Parameshwaran Krishnasamy <Parameshwaran.K@ibm.com>
@Paramesh324 Paramesh324 force-pushed the eliminate_ginkgo_ordered branch from 970b38d to 6ba1d7b Compare March 18, 2026 11:52
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2026
@Paramesh324 Paramesh324 force-pushed the eliminate_ginkgo_ordered branch 2 times, most recently from efe5406 to 6ba1d7b Compare March 20, 2026 07:40
@k8s-ci-robot
Copy link
Contributor

@Paramesh324: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-integration-baseline-main 6ba1d7b link true /test pull-kueue-test-integration-baseline-main
pull-kueue-test-integration-extended-main 6ba1d7b link true /test pull-kueue-test-integration-extended-main
pull-kueue-verify-main 6ba1d7b link true /test pull-kueue-verify-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/testing Testing - related stuff cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eliminate ginkgo.Ordered for singlecluster integration tests

4 participants