[integration] Drop ginkgo.Ordered from singlecluster tests to enable parallelism#9972
[integration] Drop ginkgo.Ordered from singlecluster tests to enable parallelism#9972Paramesh324 wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Paramesh324 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
Welcome @Paramesh324! |
|
Hi @Paramesh324. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
| var _ = ginkgo.Describe("AdmissionCheck controller", ginkgo.Label("controller:admissioncheck", "area:core"), func() { | ||
| var ns *corev1.Namespace | ||
|
|
||
| ginkgo.BeforeAll(func() { |
There was a problem hiding this comment.
BeforeAll() not working without ginkgo.Ordered.
There was a problem hiding this comment.
Just a small question from my end, do we need to add ginkgo.Ordered back on all the Describe/When/Context blocks that use BeforeAll() or only in this particular file would be sufficient.
There was a problem hiding this comment.
Can we move this logic to BeforeEach()?
There was a problem hiding this comment.
For the BeforeAll() issue, should we move manager setup to BeforeEach() once across all singlecluster intergration tests that use BeforeAll()?
…parallelism Signed-off-by: Parameshwaran Krishnasamy <Parameshwaran.K@ibm.com>
Signed-off-by: Parameshwaran Krishnasamy <Parameshwaran.K@ibm.com>
970b38d to
6ba1d7b
Compare
efe5406 to
6ba1d7b
Compare
|
@Paramesh324: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
/area testing
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #9880
Special notes for your reviewer:
Removes ginkgo.Ordered from all suites under
test/integration/singlecluster, so specs can run in arbitrary order and parallel worker. Dropping Ordered allows ginkgo to randomize and parallelize these specs.Does this PR introduce a user-facing change?