Revert to vm-op api version v1alpha4 for vks #3697

nikhilbarge · 2025-10-21T07:09:57Z

What this PR does / why we need it:
Revert to vm-op api version v1alpha4 for VKS release.
VKS should use only GAed versions of VMOP api and not api version under development.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
Manual Testing:
Tested with supervisor have VirtualMachines with VMOP api version v1alpha4

root@422dd690a950f7057161a85aeed157f3 [ ~ ]# k get pod -n vmware-system-csi -o wide
NAME                                      READY   STATUS    RESTARTS   AGE   IP            NODE                                      NOMINATED NODE   READINESS GATES
vsphere-csi-controller-79686896b4-j6bmh   7/7     Running   0          20m   100.96.5.2    wl-antrea-5twtz-wt2cv                     <none>           <none>
vsphere-csi-node-dkj2t                    3/3     Running   0          13m   10.246.0.35   wl-antrea-node-pool-1-t82dh-b42bc-9ljwg   <none>           <none>
vsphere-csi-node-h5pdp                    3/3     Running   0          13m   10.246.0.37   wl-antrea-node-pool-1-t82dh-b42bc-mfwhn   <none>           <none>
vsphere-csi-node-l6srb                    3/3     Running   0          13m   10.246.0.36   wl-antrea-node-pool-1-t82dh-b42bc-q8s5k   <none>           <none>
vsphere-csi-node-tfm5b                    3/3     Running   0          13m   10.246.0.34   wl-antrea-5twtz-fmt67                     <none>           <none>
vsphere-csi-node-w27zc                    3/3     Running   0          13m   10.246.0.38   wl-antrea-5twtz-lq6f9                     <none>           <none>
vsphere-csi-node-zjgh5                    3/3     Running   0          13m   10.246.0.39   wl-antrea-5twtz-wt2cv                     <none>           <none>
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# k get csinode wl-antrea-node-pool-1-t82dh-b42bc-9ljwg -o yaml
apiVersion: storage.k8s.io/v1
kind: CSINode
metadata:
  annotations:
    storage.alpha.kubernetes.io/migrated-plugins: kubernetes.io/aws-ebs,kubernetes.io/azure-disk,kubernetes.io/azure-file,kubernetes.io/cinder,kubernetes.io/gce-pd,kubernetes.io/portworx-volume,kubernetes.io/vsphere-volume
  creationTimestamp: "2025-10-21T08:57:12Z"
  name: wl-antrea-node-pool-1-t82dh-b42bc-9ljwg
  ownerReferences:
  - apiVersion: v1
    kind: Node
    name: wl-antrea-node-pool-1-t82dh-b42bc-9ljwg
    uid: e8df86c9-c8a9-4560-b9be-ddee59d0160c
  resourceVersion: "8896"
  uid: f8635eb7-8f7f-488a-8c4b-4f20ea643ba4
spec:
  drivers:
  - allocatable:
      count: 59
    name: csi.vsphere.vmware.com
    nodeID: wl-antrea-node-pool-1-t82dh-b42bc-9ljwg
    topologyKeys:
    - topology.kubernetes.io/zone
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# k apply -f pvc.yaml
persistentvolumeclaim/example-raw-block-pvc created
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# k get pvc 
NAME                    STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS           VOLUMEATTRIBUTESCLASS   AGE
example-raw-block-pvc   Bound    pvc-291ca812-7900-42a7-8c18-87569787265a   5Gi        RWO            worker-storagepolicy   <unset>                 3m2s
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# k get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                           STORAGECLASS           VOLUMEATTRIBUTESCLASS   REASON   AGE
pvc-291ca812-7900-42a7-8c18-87569787265a   5Gi        RWO            Delete           Bound    default/example-raw-block-pvc   worker-storagepolicy   <unset>                          36s
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# k describe pv
Name:              pvc-291ca812-7900-42a7-8c18-87569787265a
...
Status:            Bound
Claim:             default/example-raw-block-pvc
Reclaim Policy:    Delete
Access Modes:      RWO
VolumeMode:        Block
Capacity:          5Gi
Node Affinity:     
  Required Terms:  
    Term 0:        topology.kubernetes.io/zone in [domain-c11]
Message:           
Source:
    Type:              CSI (a Container Storage Interface (CSI) volume source)
    Driver:            csi.vsphere.vmware.com
    FSType:            
    VolumeHandle:      d5cbe47d-b609-4a3e-a169-118db61d2361-291ca812-7900-42a7-8c18-87569787265a
    ReadOnly:          false
    VolumeAttributes:      storage.kubernetes.io/csiProvisionerIdentity=1761038247699-166-csi.vsphere.vmware.com
                           type=vSphere CNS Block Volume
Events:                <none>
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# k apply -f pod.yaml
pod/example-raw-block-pod created
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# k get pod -o wide
NAME                    READY   STATUS    RESTARTS   AGE     IP           NODE                                      NOMINATED NODE   READINESS GATES
example-raw-block-pod   1/1     Running   0          2m37s   100.96.2.7   wl-antrea-node-pool-1-t82dh-b42bc-mfwhn   <none>           <none>
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# 

######## ON SUPERVISOR ############
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# export KUBECONFIG=
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# k get vm -A 
NAMESPACE   NAME                                      POWER-STATE   AGE
test-ns     wl-antrea-5twtz-fmt67                     PoweredOn     47m
test-ns     wl-antrea-5twtz-lq6f9                     PoweredOn     39m
test-ns     wl-antrea-5twtz-wt2cv                     PoweredOn     32m
test-ns     wl-antrea-node-pool-1-t82dh-b42bc-9ljwg   PoweredOn     40m
test-ns     wl-antrea-node-pool-1-t82dh-b42bc-mfwhn   PoweredOn     40m
test-ns     wl-antrea-node-pool-1-t82dh-b42bc-q8s5k   PoweredOn     40m
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# 
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# k get vm -A -o yaml | grep apiVersion
apiVersion: v1
- apiVersion: vmoperator.vmware.com/v1alpha4
    - apiVersion: vmware.infrastructure.cluster.x-k8s.io/v1beta1
          apiVersion: vmware.com/v1alpha1
      apiVersion: vmoperator.vmware.com/v1alpha4
- apiVersion: vmoperator.vmware.com/v1alpha4
    - apiVersion: vmware.infrastructure.cluster.x-k8s.io/v1beta1
          apiVersion: vmware.com/v1alpha1
      apiVersion: vmoperator.vmware.com/v1alpha4
- apiVersion: vmoperator.vmware.com/v1alpha4
    - apiVersion: vmware.infrastructure.cluster.x-k8s.io/v1beta1
          apiVersion: vmware.com/v1alpha1
      apiVersion: vmoperator.vmware.com/v1alpha4
- apiVersion: vmoperator.vmware.com/v1alpha4
    - apiVersion: vmware.infrastructure.cluster.x-k8s.io/v1beta1
          apiVersion: vmware.com/v1alpha1
      apiVersion: vmoperator.vmware.com/v1alpha4
- apiVersion: vmoperator.vmware.com/v1alpha4
    - apiVersion: vmware.infrastructure.cluster.x-k8s.io/v1beta1
          apiVersion: vmware.com/v1alpha1
      apiVersion: vmoperator.vmware.com/v1alpha4
- apiVersion: vmoperator.vmware.com/v1alpha4
    - apiVersion: vmware.infrastructure.cluster.x-k8s.io/v1beta1
          apiVersion: vmware.com/v1alpha1
      apiVersion: vmoperator.vmware.com/v1alpha4
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# k get pvc -n test-ns
NAME                                                                        STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS           VOLUMEATTRIBUTESCLASS   AGE
d5cbe47d-b609-4a3e-a169-118db61d2361-291ca812-7900-42a7-8c18-87569787265a   Bound    pvc-da6d5a8e-bd2c-4251-9efb-7b419eb3521c   5Gi        RWO            worker-storagepolicy   <unset>                 7m8s
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# k get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                                                                               STORAGECLASS           VOLUMEATTRIBUTESCLASS   REASON   AGE
pvc-da6d5a8e-bd2c-4251-9efb-7b419eb3521c   5Gi        RWO            Delete           Bound    test-ns/d5cbe47d-b609-4a3e-a169-118db61d2361-291ca812-7900-42a7-8c18-87569787265a   worker-storagepolicy   <unset>                          4m39s
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# 
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# k get vm -n test-ns wl-antrea-node-pool-1-t82dh-b42bc-mfwhn 
NAME                                      POWER-STATE   AGE
wl-antrea-node-pool-1-t82dh-b42bc-mfwhn   PoweredOn     42m
root@422dd690a950f7057161a85aeed157f3 [ ~ ]# k get vm -n test-ns wl-antrea-node-pool-1-t82dh-b42bc-mfwhn -o yaml
apiVersion: vmoperator.vmware.com/v1alpha4
kind: VirtualMachine
metadata:
  ...
  name: wl-antrea-node-pool-1-t82dh-b42bc-mfwhn
  namespace: test-ns
  ...
spec:
  biosUUID: 49dbc62d-91b1-4651-afa0-55a7a9d0d78a
  ...
  volumes:
  - name: d5cbe47d-b609-4a3e-a169-118db61d2361-291ca812-7900-42a7-8c18-87569787265a
    persistentVolumeClaim:
      claimName: d5cbe47d-b609-4a3e-a169-118db61d2361-291ca812-7900-42a7-8c18-87569787265a
status:
  biosUUID: 49dbc62d-91b1-4651-afa0-55a7a9d0d78a
  ...
  nodeName: 172.21.1.108
  powerState: PoweredOn
  ...
  uniqueID: vm-83
  volumes:
  - attached: true
    diskUUID: 6000C299-97fe-2441-0dce-37e6fac7588c
    limit: 20Gi
    name: wl-antrea-node-pool-1-t82dh-b42bc-mfwhn
    requested: 20Gi
    type: Classic
    used: 16Gi
  - attached: true
    diskUUID: 6000C29d-f0be-3971-056a-7f30702f5635
    limit: 5Gi
    name: d5cbe47d-b609-4a3e-a169-118db61d2361-291ca812-7900-42a7-8c18-87569787265a
    requested: 5Gi
    type: Managed
    used: "0"
  zone: domain-c11

Full logs for manual-testing-with-supervisor-v1alpha4.log

csi-controller-logs-with-supervsior-v1alpha4.log
csi-syncer-with-supervsior-v1alpha4.log
csi-node-with-supervsior-v1alpha4.log

Tested with supervisor have VirtualMachines with VMOP api version v1alpha2

root@4209733fd61cda0bb04bd8181407050f [ ~ ]# k get pod -n vmware-system-csi   -o wide
NAME                                    READY   STATUS    RESTARTS   AGE     IP              NODE                                      NOMINATED NODE   READINESS GATES
vsphere-csi-controller-9b6b4c4f-vq777   7/7     Running   0          2m10s   100.96.6.2      wl-antrea-xprqv-8wnh2                     <none>           <none>
vsphere-csi-node-6pmkm                  3/3     Running   0          18s     192.168.128.4   wl-antrea-node-pool-1-rzvfp-5m24d-7pm4f   <none>           <none>
vsphere-csi-node-89t7g                  3/3     Running   0          18s     192.168.128.3   wl-antrea-xprqv-ncqdd                     <none>           <none>
vsphere-csi-node-lqgcp                  3/3     Running   0          18s     192.168.128.7   wl-antrea-xprqv-nztcp                     <none>           <none>
vsphere-csi-node-njvnk                  3/3     Running   0          18s     192.168.128.8   wl-antrea-xprqv-8wnh2                     <none>           <none>
vsphere-csi-node-s69s9                  3/3     Running   0          18s     192.168.128.5   wl-antrea-node-pool-1-rzvfp-5m24d-l6vfg   <none>           <none>
vsphere-csi-node-xwjmj                  3/3     Running   0          18s     192.168.128.6   wl-antrea-node-pool-1-rzvfp-5m24d-qxxt9   <none>           <none>
root@4209733fd61cda0bb04bd8181407050f [ ~ ]#  k get csinode wl-antrea-node-pool-1-rzvfp-5m24d-7pm4f -o yaml
apiVersion: storage.k8s.io/v1
kind: CSINode
metadata:
  annotations:
    storage.alpha.kubernetes.io/migrated-plugins: kubernetes.io/aws-ebs,kubernetes.io/azure-disk,kubernetes.io/azure-file,kubernetes.io/cinder,kubernetes.io/gce-pd,kubernetes.io/portworx-volume,kubernetes.io/vsphere-volume
  creationTimestamp: "2025-10-21T09:10:22Z"
  name: wl-antrea-node-pool-1-rzvfp-5m24d-7pm4f
  ownerReferences:
  - apiVersion: v1
    kind: Node
    name: wl-antrea-node-pool-1-rzvfp-5m24d-7pm4f
    uid: 2cdfe6fb-3bf4-4107-a44b-524bcfd18531
  resourceVersion: "14242"
  uid: 23890c39-6738-4a6d-941c-931b5319e010
spec:
  drivers:
  - allocatable:
      count: 59
    name: csi.vsphere.vmware.com
    nodeID: wl-antrea-node-pool-1-rzvfp-5m24d-7pm4f
    topologyKeys:
    - topology.kubernetes.io/zone
root@4209733fd61cda0bb04bd8181407050f [ ~ ]# k apply -f pvc.yaml
persistentvolumeclaim/example-raw-block-pvc created
root@4209733fd61cda0bb04bd8181407050f [ ~ ]# k get pvc 
NAME                    STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS                VOLUMEATTRIBUTESCLASS   AGE
example-raw-block-pvc   Bound    pvc-6faa34dd-6a54-4c2c-bb6f-c6dabd9dd91b   5Gi        RWO            wcpglobal-storage-profile   <unset>                 10s
root@4209733fd61cda0bb04bd8181407050f [ ~ ]# k get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                           STORAGECLASS                VOLUMEATTRIBUTESCLASS   REASON   AGE
pvc-6faa34dd-6a54-4c2c-bb6f-c6dabd9dd91b   5Gi        RWO            Delete           Bound    default/example-raw-block-pvc   wcpglobal-storage-profile   <unset>                          22s
root@4209733fd61cda0bb04bd8181407050f [ ~ ]# k describe pv
Name:            pvc-6faa34dd-6a54-4c2c-bb6f-c6dabd9dd91b
...
StorageClass:    wcpglobal-storage-profile
Status:          Bound
Claim:           default/example-raw-block-pvc
Reclaim Policy:  Delete
Access Modes:    RWO
VolumeMode:      Block
Capacity:        5Gi
Node Affinity:   <none>
Message:         
Source:
    ...
    VolumeHandle:      74c5eacc-e5f9-4476-b788-5149eb9ed2e5-6faa34dd-6a54-4c2c-bb6f-c6dabd9dd91b
    ReadOnly:          false
    ...
Events:                <none>
root@4209733fd61cda0bb04bd8181407050f [ ~ ]# k apply -f pod.yaml 
pod/example-raw-block-pod created
root@4209733fd61cda0bb04bd8181407050f [ ~ ]# k get pod  -o wide
NAME                    READY   STATUS    RESTARTS   AGE   IP           NODE                                      NOMINATED NODE   READINESS GATES
example-raw-block-pod   1/1     Running   0          25s   100.96.1.9   wl-antrea-node-pool-1-rzvfp-5m24d-qxxt9   <none>           <none>
root@4209733fd61cda0bb04bd8181407050f [ ~ ]#



################### ON SUPERVISOR #####################

root@4209733fd61cda0bb04bd8181407050f [ ~ ]# export KUBECONFIG=
root@4209733fd61cda0bb04bd8181407050f [ ~ ]# k get vm -A
NAMESPACE   NAME                                      POWER-STATE   AGE
test-ns     wl-antrea-node-pool-1-rzvfp-5m24d-7pm4f   PoweredOn     57m
test-ns     wl-antrea-node-pool-1-rzvfp-5m24d-l6vfg   PoweredOn     57m
test-ns     wl-antrea-node-pool-1-rzvfp-5m24d-qxxt9   PoweredOn     57m
test-ns     wl-antrea-xprqv-8wnh2                     PoweredOn     48m
test-ns     wl-antrea-xprqv-ncqdd                     PoweredOn     65m
test-ns     wl-antrea-xprqv-nztcp                     PoweredOn     54m
root@4209733fd61cda0bb04bd8181407050f [ ~ ]# k get vm -A -o yaml | grep apiVersion
apiVersion: v1
- apiVersion: vmoperator.vmware.com/v1alpha2
    - apiVersion: vmware.infrastructure.cluster.x-k8s.io/v1beta1
          apiVersion: netoperator.vmware.com/v1alpha1
      apiVersion: vmoperator.vmware.com/v1alpha2
      apiVersion: vmoperator.vmware.com/v1alpha2
- apiVersion: vmoperator.vmware.com/v1alpha2
    - apiVersion: vmware.infrastructure.cluster.x-k8s.io/v1beta1
          apiVersion: netoperator.vmware.com/v1alpha1
      apiVersion: vmoperator.vmware.com/v1alpha2
      apiVersion: vmoperator.vmware.com/v1alpha2
- apiVersion: vmoperator.vmware.com/v1alpha2
    - apiVersion: vmware.infrastructure.cluster.x-k8s.io/v1beta1
          apiVersion: netoperator.vmware.com/v1alpha1
      apiVersion: vmoperator.vmware.com/v1alpha2
      apiVersion: vmoperator.vmware.com/v1alpha2
- apiVersion: vmoperator.vmware.com/v1alpha2
    - apiVersion: vmware.infrastructure.cluster.x-k8s.io/v1beta1
          apiVersion: netoperator.vmware.com/v1alpha1
      apiVersion: vmoperator.vmware.com/v1alpha2
      apiVersion: vmoperator.vmware.com/v1alpha2
- apiVersion: vmoperator.vmware.com/v1alpha2
    - apiVersion: vmware.infrastructure.cluster.x-k8s.io/v1beta1
          apiVersion: netoperator.vmware.com/v1alpha1
      apiVersion: vmoperator.vmware.com/v1alpha2
      apiVersion: vmoperator.vmware.com/v1alpha2
- apiVersion: vmoperator.vmware.com/v1alpha2
    - apiVersion: vmware.infrastructure.cluster.x-k8s.io/v1beta1
          apiVersion: netoperator.vmware.com/v1alpha1
      apiVersion: vmoperator.vmware.com/v1alpha2
      apiVersion: vmoperator.vmware.com/v1alpha2
root@4209733fd61cda0bb04bd8181407050f [ ~ ]# k get pvc -n test-ns
NAME                                                                        STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS                VOLUMEATTRIBUTESCLASS   AGE
74c5eacc-e5f9-4476-b788-5149eb9ed2e5-6faa34dd-6a54-4c2c-bb6f-c6dabd9dd91b   Bound    pvc-ea1ad50b-b91b-4563-bbd8-bff842a8e0ac   5Gi        RWO            wcpglobal-storage-profile   <unset>                 5m3s
root@4209733fd61cda0bb04bd8181407050f [ ~ ]# k get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                                                                               STORAGECLASS                VOLUMEATTRIBUTESCLASS   REASON   AGE
pvc-ea1ad50b-b91b-4563-bbd8-bff842a8e0ac   5Gi        RWO            Delete           Bound    test-ns/74c5eacc-e5f9-4476-b788-5149eb9ed2e5-6faa34dd-6a54-4c2c-bb6f-c6dabd9dd91b   wcpglobal-storage-profile   <unset>                          5m6s
root@4209733fd61cda0bb04bd8181407050f [ ~ ]# 
root@4209733fd61cda0bb04bd8181407050f [ ~ ]# k get vm -n test-ns wl-antrea-node-pool-1-rzvfp-5m24d-qxxt9 -o yaml
apiVersion: vmoperator.vmware.com/v1alpha2
kind: VirtualMachine
metadata:
  ...
  name: wl-antrea-node-pool-1-rzvfp-5m24d-qxxt9
  namespace: test-ns
  ...
spec:
  ...
  volumes:
  - name: 74c5eacc-e5f9-4476-b788-5149eb9ed2e5-6faa34dd-6a54-4c2c-bb6f-c6dabd9dd91b
    persistentVolumeClaim:
      claimName: 74c5eacc-e5f9-4476-b788-5149eb9ed2e5-6faa34dd-6a54-4c2c-bb6f-c6dabd9dd91b
status:
  biosUUID: 4209bc18-5091-44eb-f524-dacf7e63e05c
  ...
  powerState: PoweredOn
  uniqueID: vm-82
  volumes:
  - attached: true
    diskUUID: 6000C298-10a0-955a-ac38-e5ac1ca4171f
    name: 74c5eacc-e5f9-4476-b788-5149eb9ed2e5-6faa34dd-6a54-4c2c-bb6f-c6dabd9dd91b
  zone: domain-c9

revert-v1alpha4-manual-test-with-supervisor-v1alpha2.log
revert-v1alpha4-csi-controller-with-supervisor-v1alpha2.log
revert-v1alpha4-csi-syncer-with-supervisor-v1alpha2.log
revert-v1alpha4-csi-node-with-supervisor-v1alpha2.log

Special notes for your reviewer:

Release note:

Revert to vm-op api version v1alpha4 for VKS

k8s-ci-robot · 2025-10-21T07:10:05Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nikhilbarge
Once this PR has been reviewed and has the lgtm label, please assign akankshapanse for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-10-21T07:10:07Z

Hi @nikhilbarge. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

deepakkinni · 2025-10-21T08:53:04Z

FAILED --- Jenkins Build #496

deepakkinni · 2025-10-21T10:52:13Z

FAILED --- Jenkins Build #498

deepakkinni · 2025-10-21T17:24:31Z

/ok-to-test

kolluria · 2025-10-22T07:13:46Z

tests/e2e/vmservice_utils.go

 }

 // getVmsvcVM fetches the vm from the specified ns
 func getVmsvcVM5(


@nikhilbarge can't we just use getVmsvcVM4 func and remove this one?

kolluria · 2025-10-22T07:22:02Z

@nikhilbarge could you update the description explaining why we're removing VM Snapshots?

kolluria · 2025-10-22T07:26:42Z

@nikhilbarge what are the compatible Supervisor versions for VKS 3.5? Just wondering if our code needs to handle vm versions from alpha1 to 4

kolluria · 2025-10-22T07:24:48Z

pkg/csi/service/wcpguest/controller.go

 	vmoperatorv1alpha1 "github.com/vmware-tanzu/vm-operator/api/v1alpha1"
 	vmoperatorv1alpha2 "github.com/vmware-tanzu/vm-operator/api/v1alpha2"
 	vmoperatorv1alpha3 "github.com/vmware-tanzu/vm-operator/api/v1alpha3"
 	vmoperatorv1alpha4 "github.com/vmware-tanzu/vm-operator/api/v1alpha4"


Can we name this import to vmoplatest or something similar so that we don't have to change so many lines every time we move to a new version?

Let's follow the same wherever applicable.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2025

k8s-ci-robot requested review from gnufied and kavyashree-r October 21, 2025 07:10

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 21, 2025

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 21, 2025

Revert to vm-op api version v1alpha4 for vks

417bfdc

nikhilbarge force-pushed the revert_to_v1alpha4_for_vks branch from 53dabf5 to 417bfdc Compare October 21, 2025 07:37

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 21, 2025

kolluria reviewed Oct 22, 2025

View reviewed changes

kolluria suggested changes Oct 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert to vm-op api version v1alpha4 for vks #3697

Revert to vm-op api version v1alpha4 for vks #3697

nikhilbarge commented Oct 21, 2025 •

edited

Loading

Uh oh!

k8s-ci-robot commented Oct 21, 2025

Uh oh!

k8s-ci-robot commented Oct 21, 2025

Uh oh!

deepakkinni commented Oct 21, 2025

Uh oh!

deepakkinni commented Oct 21, 2025

Uh oh!

deepakkinni commented Oct 21, 2025

Uh oh!

kolluria Oct 22, 2025

Uh oh!

kolluria commented Oct 22, 2025

Uh oh!

kolluria commented Oct 22, 2025

Uh oh!

kolluria Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Revert to vm-op api version v1alpha4 for vks #3697

Are you sure you want to change the base?

Revert to vm-op api version v1alpha4 for vks #3697

Conversation

nikhilbarge commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Oct 21, 2025

Uh oh!

k8s-ci-robot commented Oct 21, 2025

Uh oh!

deepakkinni commented Oct 21, 2025

Uh oh!

deepakkinni commented Oct 21, 2025

Uh oh!

deepakkinni commented Oct 21, 2025

Uh oh!

kolluria Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

kolluria commented Oct 22, 2025

Uh oh!

kolluria commented Oct 22, 2025

Uh oh!

kolluria Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nikhilbarge commented Oct 21, 2025 •

edited

Loading