[cluster-autoscaler-release-1.30] update Makefile and Dockerfile #8689
+31
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/provider/externalgrpc
|
/assign @towca @x13n @BigDarkClown |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmd-soliman, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
towca
reviewed
Oct 28, 2025
| ARG BASEIMAGE=gcr.io/distroless/static:nonroot-amd64 | ||
| FROM $BASEIMAGE | ||
| LABEL maintainer="Marcin Wielgus <[email protected]>" | ||
| FROM --platform=$BUILDPLATFORM golang:1.24 as builder |
There was a problem hiding this comment.
It's probably best to match the builder Go version with K8s, and it looks like k8s uses Go 1.23.10 for 1.30: https://github.com/kubernetes/kubernetes/blob/release-1.30/.go-version
|
Left a comment about the Go version used to build, otherwise LGTM! Leaving a hold to address the comment. /lgtm |
k8s-ci-robot
added
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
While repro'ing #8670 I observed that the
cluster-autoscaler-release-1.30branch had an old Makefile and Dockerfile compared to recent branches. This PR makes it more ergnomic to cut a release on this (officially out of support) branch.Incorporates changes from https://github.com/kubernetes/autoscaler/pull/8042/files
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: