-
Notifications
You must be signed in to change notification settings - Fork 316
Fixed metrics collector aggregation issue for NEG metrics in MT #2952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @priyapande. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @swetharepakula @panslava |
55c0448
to
e676fe4
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: priyapande The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6f95f96
to
2c6582b
Compare
/ok-to-test |
a791ae2
to
c87b6a2
Compare
b11fb53
to
ce4a3b5
Compare
ce4a3b5
to
e58a5ac
Compare
7735b8a
to
ee89d0e
Compare
ee89d0e
to
1b71aa5
Compare
To allow providerConfigId to be set for multi-project use-cases, added a new NegMetrics struct that registers to the existing metrics methods so we can use it as an additional label in all our metrics to support per NEG controller metrics.
Meanwhile, fixed the bug by creating a global metrics collector that aggregates the metrics based on NegSyncerKey.
Merge depends on - #2951