feat: add metric about tls cert expiration in secrets#2846
feat: add metric about tls cert expiration in secrets#2846sylr wants to merge 1 commit intokubernetes:mainfrom
Conversation
|
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sylr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
6924673 to
fe42789
Compare
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
fe42789 to
016552e
Compare
|
The below is my opinion and a description of my concerns from a non-maintainer's perspective. There is no ill-intent and I respect the time and effort it takes to contribute. Please read this with a few 😄 in between! KSM may not be the right place to monitor details of a TLS certificate. I'd argue the data inside of a secret is not directly pertinent to the state of a Kubernetes cluster itself. The inability to report problems with decoding the certificate may also add ambiguity when troubleshooting problems where the metric does not appear for a given secret containing a TLS certificate. Kubernetes offers sugarcoating by means of the TLS secret type to more easily manage TLS certificates as secrets. However, the Kubernetes API itself does not directly interpret or subsequently expose any details about the TLS certificate.
Decoding of (semi-)unknown data should not be KSM's responsibility. |
What this PR does / why we need it:
Add a
kube_secret_tls_cert_not_after_secondsto get certificate expiration dates.How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Increase cardinality.