feat: add new kube_service_spec_ports metric#2849
feat: add new kube_service_spec_ports metric#2849Serializator wants to merge 3 commits intokubernetes:mainfrom
Conversation
|
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Serializator The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
a35c311 to
dc2f674
Compare
Signed-off-by: Julian van den Berkmortel <7153670+Serializator@users.noreply.github.com>
Signed-off-by: Julian van den Berkmortel <7153670+Serializator@users.noreply.github.com>
Signed-off-by: Julian van den Berkmortel <7153670+Serializator@users.noreply.github.com>
dc2f674 to
e9da2b6
Compare
|
Hey @dgrisonnet & @mrueg! Would one of you have time to approve the workflow so tests can run? Thank you in advance! |
What this PR does / why we need it:
Add new metric
kube_service_spec_portsto represent ports on the service resource.The
kube_service_spec_prefix matches with the naming convention for the rest of the metrics.To stay aligned with other metrics,
.spec.ports.appProtocolis not included as a label. The same is true for thekube_endpoint_addressmetric..spec.ports.targetPortis not included as a label due to its inconsistent value. It can be a named port or port number.How does this change affect the cardinality of KSM:
Increases cardinality with a new time series.
Which issue(s) this PR fixes:
Fixes #2819