-
Notifications
You must be signed in to change notification settings - Fork 600
feat: Add performance tests for custom-resource-state-metrics
#3483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Welcome @Rishab87! |
Hi @Rishab87. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Rishab87 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Rishab87 Hello, thank you for this! Since this is a draft, I'm assuming there's some pending changes left here? |
@rexagod yes, I'm not able to see performance metrics in logs, I need to fix that, I will mark it ready for review once it is fixed. Would really appreciate any help on this otherwise I'll try to get it done by next week. |
@mborsz @wojtek-t , Im still stuck at this do you have any idea? I'm able to run the tests with this command: ./clusterloader2/clusterloader --testconfig=./clusterloader2/testing/prometheus/custom-resource-state-metrics.yaml --provider=kind --kubeconfig=$HOME/.kube/config --v=2 The tests pass:
But I am not able to see the performance metrics it also finishes very soon to under 10 secs. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR introduces performance tests for the custom-resource-state-metrics feature, as requested in the issue.
It adds two parallel test scenarios to compare the performance of KSM's native namespace collector against the new custom-resource-state collector for the same workload (500 namespaces with 5 labels each). This allows for a direct performance comparison between the two modes.
Which issue(s) this PR fixes:
Fixes kubernetes/kube-state-metrics#1902
Special notes for your reviewer:
This is my first time ever contributing to k8s, I'm not able to see performance metrics in logs, the tests pass, would really appreciate reviews & some help on this.