validate-rules: use base-branch local staging checks#537
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Feb 28, 2026
Merged
Conversation
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Member
Author
|
we always run into this when we want to iterate on creation of a new staging repo! |
Member
Author
|
/assign @akhilerm |
dims
added
the
lgtm
akhilerm
reviewed
Mar 2, 2026
| // EnsureStagingDirectoriesExist walks through the repository rules and checks | ||
| // if the specified directories are present in the specific kubernetes branch. | ||
| func EnsureStagingDirectoriesExist(rules *config.RepositoryRules, baseBranch string) []error { | ||
| func EnsureStagingDirectoriesExist(rules *config.RepositoryRules, baseBranch, rulesFile string) []error { |
Member
There was a problem hiding this comment.
Why do we need the rulesFile here? only for getting the kuberoot?
| func checkDirectoryExists(directory, branch, baseBranch, kubeRoot string) error { | ||
| if branch == baseBranch { | ||
| localPath := filepath.Join(kubeRoot, "staging", "src", "k8s.io", directory) | ||
| if info, err := os.Stat(localPath); err == nil && info.IsDir() { |
Member
There was a problem hiding this comment.
If a directory does not exist in the local checkout, but exists when fetching via an API, doesnt it mean the content in the PR is wrong and it should fail the job?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Why:
Validation: