Conversation
|
You can remove manifests/extras/nginx. It is not working and nobody is using it. Assigned you the relevant Jira ticket. |
|
Why did you rename |
|
"Removed deprecated warnings" - Is that achieved through the removal of the "beta." prefix? |
| delete () { | ||
| echo "Deleting sock-shop namespace resources" | ||
| kubectl delete all --all -n sock-shop | ||
| kubectl delete namespace sock-shop || true |
There was a problem hiding this comment.
What does the || true do?
If the delete operation fail, why would we want to suppress the error?
| echo "Deploying sock-shop namespace" | ||
| kubectl create -f manifests/sock-shop-ns.yaml | ||
|
|
||
| echo "Deploying sock-shop core" | ||
| kubectl apply $(ls manifests/*[[:digit:]]*.yaml | awk ' { print " -f " $1 } ') | ||
|
|
||
| echo "Deploying sock-shop-mizu extras" | ||
| kubectl apply $(ls manifests/extras/*[[:digit:]]*.yaml | awk ' { print " -f " $1 } ') |
There was a problem hiding this comment.
| echo "Deploying sock-shop namespace" | |
| kubectl create -f manifests/sock-shop-ns.yaml | |
| echo "Deploying sock-shop core" | |
| kubectl apply $(ls manifests/*[[:digit:]]*.yaml | awk ' { print " -f " $1 } ') | |
| echo "Deploying sock-shop-mizu extras" | |
| kubectl apply $(ls manifests/extras/*[[:digit:]]*.yaml | awk ' { print " -f " $1 } ') | |
| echo "Deploying sock-shop" | |
| kubectl create -f complete-demo.yaml |
|
In principal this PR should have been several PRs. (Fix warnings, remove NGINX, add scripts). |
|
Document script usage in one of the markdown files. |
|
@gustavomassa @nimrod-up9 any update on this PR? |
|
@gustavomassa @nimrod-up9 - any update? |
|
I don't have any more comments besides what I already wrote. Waiting for the fixes/answers. |
|
btw, who requested this? We have gone a long time without merging this branch. Is it still necessary or should we close without merging? |
4 participants
Created a script to deploy sock-shop to kubernetes minikube/cluster
Created a script to delete all sock-shop/monitoring/default resources of kubernetes cluster
Renamed nginx-ingress-controller to not deploy it automatically
Removed deprecated warnings
TODO: Figure out how to port-forward/expose Grafana/Prometheus services on the real cluster