MTV-4058 - part 2 - clone rp-uploader on runtime #2192
Merged
+16
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update CreateProviderPage selectors for new form structure - Add provider-specific field methods (vSphere, OVA, OVirt) - Parametrize provider creation tests using test scenarios - Update StorageMapStep to correctly parse source storage column - Update test data for current environment Resolves: MTV-3741 Signed-off-by: Pedro Abreu <[email protected]>
- Bump Playwright and @playwright/test versions to 1.57.0 in package.json - Update PlaywrightContainerFile to use the new Playwright image version - Remove the deprecated upload-to-rp.sh script - Expect rp-upload on runtime Resolves: MTV-4058 Signed-off-by: Pedro Abreu <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2192 +/- ##
===========================================
- Coverage 36.81% 13.75% -23.07%
===========================================
Files 158 1107 +949
Lines 2548 19773 +17225
Branches 599 3696 +3097
===========================================
+ Hits 938 2719 +1781
- Misses 1428 17044 +15616
+ Partials 182 10 -172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pedro-S-Abreu
changed the title
Resolves: None Signed-off-by: Pedro Abreu <[email protected]>
avivtur
reviewed
Jan 19, 2026
Comment on lines
50
to
52
| if (testProviderData.useVddkAioOptimization === true) { | ||
| expect(providerResource?.spec?.settings?.useVddkAioOptimization).toBe('true'); | ||
| } | ||
| if (!testProviderData.useVddkAioOptimization) { | ||
| } else if (testProviderData.useVddkAioOptimization === false) { |
Member
There was a problem hiding this comment.
why this lines keeps repeating?
Collaborator
Author
There was a problem hiding this comment.
It was an old local change, for some reason it stayed. I just fixed it.
Resolves: None Signed-off-by: Pedro Abreu <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Links
https://issues.redhat.com/browse/MTV-4058
📝 Description
rp-uploader can not be cloned during container image build time due to gitlab permission/connectivity issues.
the other part of this work is contained on
https://gitlab.cee.redhat.com/ccit/jenkins-csb-customers/mtv-qe-casc-main/-/merge_requests/211
🎥 Demo
📝 CC://