ECOPROJECT-3571 | feat: remove the short term solution for: ECOPROJECT-3489 upgrade for support

[AvielSegev]

After merging this PR into forklift repository: kubev2v/forklift#3983
we can merge this one.

Signed-off-by: Aviel Segev [email protected]

Summary by CodeRabbit

• Bug Fixes
  • Removed OS upgrade recommendation notifications from virtual machine assessments.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign avielsegev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request removes the OS upgrade recommendation feature from the codebase. This includes deleting the entire internal/opa/recommendations.go file containing OS upgrade mapping and concern generation logic, and removing the corresponding import and function invocation from internal/agent/collector/os_info.go.

Changes

Cohort / File(s)	Summary
OS upgrade recommendation removal internal/opa/recommendations.go	Entire file deleted, including OSUpgradeMap, getOSUpgradeConcern(), and AddOSUpgradeConcernToVM() function
OS info collector cleanup internal/agent/collector/os_info.go	Removed import of internal/opa and removed call to opa.AddOSUpgradeConcernToVM() within updateOsInfo function

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• PR #765 — Introduced the OS upgrade recommendation feature that this PR removes (AddOSUpgradeConcernToVM and related logic)

Suggested labels

lgtm

Suggested reviewers

• tupyy
• ronenav
• machacekondra
• Jos-Jerus

Poem

🐰 ✨ The upgrade paths hop away,
No more concerns to delay the day,
Clean code bounds with lighter stride—
Simplicity's our joyful guide! 🎯

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly indicates the PR removes a short-term solution for OS upgrade recommendations, which aligns with the changeset that removes OS upgrade concern logic from two files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e121207 and d521eca.

📒 Files selected for processing (2)

• internal/agent/collector/os_info.go
• internal/opa/recommendations.go

💤 Files with no reviewable changes (2)

• internal/agent/collector/os_info.go
• internal/opa/recommendations.go

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: Red Hat Konflux / migration-planner-agent-on-pull-request
• GitHub Check: Red Hat Konflux / migration-planner-rhcos-iso-on-pull-request
• GitHub Check: Red Hat Konflux / migration-planner-api-on-pull-request
• GitHub Check: check-generate
• GitHub Check: lint
• GitHub Check: unit-test
• GitHub Check: test

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[nirarg]

/hold
blocked by kubev2v/forklift#3983