Chore: upgrades go, golang_ci, and staticcheck version#204
Merged
anoop2811 merged 5 commits intokubevela:mainfrom Apr 30, 2025
Merged
Conversation
Signed-off-by: Ayush Shyam Kumar <ayushshyam.official.888@gmail.com>
PushparajShetty
requested review from
FogDong,
Somefive,
leejanee and
wonderflow
as code owners
PushparajShetty
changed the title
Signed-off-by: Ayush Shyam Kumar <ayushshyam.official.888@gmail.com>
Signed-off-by: Ayush Shyam Kumar <ayushshyam.official.888@gmail.com>
Signed-off-by: Ayush Shyam Kumar <ayushshyam.official.888@gmail.com>
Signed-off-by: Ayush Shyam Kumar <ayushshyam.official.888@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Go version and associated tooling to support improved performance and new linting features. In addition, it updates various GitHub workflow configurations and corrects minor issues in error messaging.
- Upgraded Go version to 1.23.8 and golangci-lint version to 1.60.1.
- Updated GitHub workflow runners from Ubuntu 20.04 to Ubuntu 22.04.
- Corrected typo in error messages in Prometheus metric check functions.
Reviewed Changes
Copilot reviewed 12 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/webhook/v1alpha1/workflowrun/validating_handler.go | Changed error formatting to safely wrap the error message. |
| pkg/providers/metrics/prom_check.go | Fixed typo ("ehe" to "the") in the error message returned by getQueryResult. |
| pkg/providers/legacy/metrics/prom_check.go | Fixed typo ("ehe" to "the") in the error message returned by getQueryResult. |
| cmd/main.go | Corrected the usage of errors.Is to properly check the returned error. |
| .golangci.yml | Updated configuration keys to match the new version requirements. |
| .github/workflows/* | Upgraded Go and golangci versions and updated runner images to Ubuntu 22.04. |
Files not reviewed (4)
- Dockerfile: Language not supported
- Dockerfile.e2e: Language not supported
- go.mod: Language not supported
- makefiles/dependency.mk: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
This has been tested on a patched KubeVela setup by deploying applications and multi-cluster environments. Everything is working as expected.
Special notes for your reviewer