Fix: Fixes the request workflowstep#211
Merged
FogDong merged 1 commit intokubevela:mainfrom Jun 16, 2025
Merged
Conversation
Signed-off-by: Brian Kane <briankane1@gmail.com>
There was a problem hiding this comment.
cubic reviewed 2 files and found no issues. Review PR in cubic.dev.
FogDong
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
The request workflowstep was not correctly returning response data. This fixes it to correctly wait for the response, and then sets it correctly on the response attribute.
Fixes #
kubevela/kubevela#6800
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary. (N/A)How has this code been tested
Tested and detailed as part of kubevela/kubevela#6804.
Special notes for your reviewer
This affects both Workflow standalone and Kubevela.
Associated Kubevela bug: kubevela/kubevela#6800
Associated Kubevela PR (needs this merged first): kubevela/kubevela#6804
Summary by cubic
Fixed the request workflow step so it now waits for the HTTP response and sets the response data correctly.