Skip to content

Fix: Fixes the request workflowstep#211

Merged
FogDong merged 1 commit intokubevela:mainfrom
briankane:fix/request-workflowstep-fix
Jun 16, 2025
Merged

Fix: Fixes the request workflowstep#211
FogDong merged 1 commit intokubevela:mainfrom
briankane:fix/request-workflowstep-fix

Conversation

@briankane
Copy link
Copy Markdown
Collaborator

@briankane briankane commented Jun 16, 2025

Description of your changes

The request workflowstep was not correctly returning response data. This fixes it to correctly wait for the response, and then sets it correctly on the response attribute.

Fixes #
kubevela/kubevela#6800

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary. (N/A)
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary. (N/A)

How has this code been tested

Tested and detailed as part of kubevela/kubevela#6804.

Special notes for your reviewer

This affects both Workflow standalone and Kubevela.
Associated Kubevela bug: kubevela/kubevela#6800
Associated Kubevela PR (needs this merged first): kubevela/kubevela#6804


Summary by cubic

Fixed the request workflow step so it now waits for the HTTP response and sets the response data correctly.

  • Bug Fixes
    • Ensures the workflow step waits for the HTTP response before processing.
    • Correctly sets the response attribute with the returned data.

Signed-off-by: Brian Kane <briankane1@gmail.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 2 files and found no issues. Review PR in cubic.dev.

@FogDong FogDong merged commit 59237b8 into kubevela:main Jun 16, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants