Skip to content

Chore: update dependencies and fix test cases#214

Merged
FogDong merged 3 commits intokubevela:mainfrom
roguepikachu:chore/upgrade-cue-v0.14.1
Oct 7, 2025
Merged

Chore: update dependencies and fix test cases#214
FogDong merged 3 commits intokubevela:mainfrom
roguepikachu:chore/upgrade-cue-v0.14.1

Conversation

@roguepikachu
Copy link
Copy Markdown
Contributor

@roguepikachu roguepikachu commented Oct 7, 2025

Description of your changes

This PR upgrades the CUE dependency from v0.9.2 to v0.14.1

Changes:

  • Upgraded cuelang.org/go from v0.9.2 to v0.14.1 in go.mod
  • Updated transitive dependencies via go mod tidy
  • Fixed test expectations in pkg/cue/model/sets/operation_test.go and pkg/cue/model/sets/utils_test.go to accommodate CUE v0.14.1's field ordering changes

Fixes #

I have:

  • Read and followed KubeVela's [contribution process](https://github.com/
    kubevela/kubevela/blob/master/contribute/create-pull-request.md).
  • Related Docs updated
    properly. In a new feature or configuration option, an update to the
    documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if
    necessary.

How has this code been tested

  • All packages build successfully with go build ./...
  • Core workflow tests pass with go test ./pkg/...
  • CUE model operation tests pass with updated field ordering expectations
  • No breaking API changes detected - existing CUE code compiles without
    modifications

Special notes for your reviewer

Field Ordering Changes:
CUE v0.14.1 changed how fields are ordered in formatted output. This is expected behavior as CUE fields are inherently unordered. Test expectations in pkg/cue/model/sets/operation_test.go and pkg/cue/model/sets/utils_test.go have been updated to reflect the new ordering (e.g., fields now appear in lexicographic order in some cases).


Summary by cubic

Upgraded CUE to v0.14.1 and refreshed related dependencies. Updated test expectations to match CUE’s new field ordering and corrected patch annotations.

  • Dependencies

    • cuelang.org/go v0.14.1
    • github.com/google/go-cmp v0.7.0
    • github.com/spf13/pflag v1.0.7
    • Added github.com/emicklei/proto v1.14.2 (indirect)
    • Updated golang.org/x/* packages to latest; tidied go.mod/go.sum
  • Bug Fixes

    • Adjusted pkg/cue/model/sets/operation_test.go for lexicographic field order
    • Fixed patchKey ordering and patchStrategy comment formatting

@roguepikachu roguepikachu force-pushed the chore/upgrade-cue-v0.14.1 branch from dbc74a6 to 48a5e9f Compare October 7, 2025 08:50
@roguepikachu roguepikachu changed the title chore: update dependencies and fix test cases Chore: update dependencies and fix test cases Oct 7, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.41%. Comparing base (d7db9c4) to head (b27b160).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   62.49%   67.41%   +4.92%     
==========================================
  Files          62       62              
  Lines        4415     5939    +1524     
==========================================
+ Hits         2759     4004    +1245     
- Misses       1324     1584     +260     
- Partials      332      351      +19     
Flag Coverage Δ
e2etests 20.32% <ø> (?)
unit-test 61.59% <ø> (-0.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roguepikachu roguepikachu force-pushed the chore/upgrade-cue-v0.14.1 branch from e7251f6 to 078d694 Compare October 7, 2025 09:04
- Updated cuelang.org/go from v0.9.2 to v0.14.1
- Updated github.com/google/go-cmp from v0.6.0 to v0.7.0
- Updated github.com/spf13/pflag from v1.0.5 to v1.0.7
- Added indirect dependency github.com/emicklei/proto v1.14.2
- Updated indirect dependencies including golang.org/x/crypto, golang.org/x/net, golang.org/x/oauth2, golang.org/x/sync, golang.org/x/sys, golang.org/x/term, and golang.org/x/text to their latest versions
- Fixed test cases in operation_test.go to correct patchKey and patchStrategy annotations

Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com>
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com>
Signed-off-by: Ayush Kumar <ayushshyamkumar888@gmail.com>
@roguepikachu roguepikachu force-pushed the chore/upgrade-cue-v0.14.1 branch from 4b31629 to b27b160 Compare October 7, 2025 09:19
@roguepikachu roguepikachu marked this pull request as ready for review October 7, 2025 09:25
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@FogDong FogDong merged commit 415593c into kubevela:main Oct 7, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants