Chore: updates references to structs moved to pkg repo#216
Merged
FogDong merged 6 commits intokubevela:mainfrom Oct 27, 2025
Merged
Chore: updates references to structs moved to pkg repo#216FogDong merged 6 commits intokubevela:mainfrom
FogDong merged 6 commits intokubevela:mainfrom
Conversation
Signed-off-by: Amit Singh <singhamitch@outlook.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 62.49% 70.19% +7.70%
==========================================
Files 62 62
Lines 4415 5009 +594
==========================================
+ Hits 2759 3516 +757
+ Misses 1324 1142 -182
- Partials 332 351 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Amit Singh <singhamitch@outlook.com>
cc17802 to
87af26e
Compare
semmet95
commented
Oct 16, 2025
semmet95
commented
Oct 16, 2025
There was a problem hiding this comment.
1 issue found across 24 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="Makefile">
<violation number="1" location="Makefile:38">
Adding sync-crds here makes every manifests invocation run go mod tidy, so `make test` (and other targets that depend on manifests) now mutate go.mod/go.sum whenever the module is not already tidy. Please keep tidying as an explicit step instead of coupling it to manifests.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
Signed-off-by: Amit Singh <singhamitch@outlook.com>
Contributor
Author
|
@cubic-dev-ai re-run |
@semmet95 Sorry, I encountered an error while trying to start the review. Please try again later. |
Signed-off-by: Amit Singh <singhamitch@outlook.com>
briankane
approved these changes
Oct 16, 2025
Signed-off-by: Amit Singh <singhamitch@outlook.com>
586f80b to
4639216
Compare
Signed-off-by: Vishal Kumar <vishal210893@gmail.com> Co-authored-by: Ayush Kumar <ayushshyamkumar888@gmail.com>
FogDong
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
As a part of the centralizing the CRDs and structs shared across multiple Kubevela org repos, this PR switches to the structs and CRDs stored in the
pkgrepoFixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Existing tests
Summary by cubic
Switched workflow type references to shared structs in github.com/kubevela/pkg (oam/v1alpha1) to centralize CRDs and remove duplicates. Workflow CRD registration is removed here; only WorkflowRun remains registered.
Refactors
Dependencies