Skip to content

Chore: updates references to structs moved to pkg repo#216

Merged
FogDong merged 6 commits intokubevela:mainfrom
semmet95:chore/import-shared-crds
Oct 27, 2025
Merged

Chore: updates references to structs moved to pkg repo#216
FogDong merged 6 commits intokubevela:mainfrom
semmet95:chore/import-shared-crds

Conversation

@semmet95
Copy link
Copy Markdown
Contributor

@semmet95 semmet95 commented Oct 16, 2025

Description of your changes

As a part of the centralizing the CRDs and structs shared across multiple Kubevela org repos, this PR switches to the structs and CRDs stored in the pkg repo

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Existing tests


Summary by cubic

Switched workflow type references to shared structs in github.com/kubevela/pkg (oam/v1alpha1) to centralize CRDs and remove duplicates. Workflow CRD registration is removed here; only WorkflowRun remains registered.

  • Refactors

    • Replace local Workflow, WorkflowSpec, WorkflowStep, and WorkflowExecuteMode with oamv1alpha1 equivalents.
    • Update generator, executor, hooks, tasks, utils, webhook, and tests to use pkg types.
    • Remove local DeepCopy code for moved types.
    • Stop registering Workflow in the scheme; continue registering WorkflowRun.
  • Dependencies

    • Bump github.com/kubevela/pkg to v1.9.3-0.20251015050342-14cd204ff6fc to pull shared CRDs and structs.

Signed-off-by: Amit Singh <singhamitch@outlook.com>
@semmet95 semmet95 changed the title chore: updates references to structs moved to pkg repo Chore: updates references to structs moved to pkg repo Oct 16, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.19%. Comparing base (d7db9c4) to head (160d824).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/executor/workflow.go 71.42% 2 Missing ⚠️
pkg/generator/generator.go 66.66% 1 Missing ⚠️
pkg/webhook/v1alpha1/workflowrun/validation.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   62.49%   70.19%   +7.70%     
==========================================
  Files          62       62              
  Lines        4415     5009     +594     
==========================================
+ Hits         2759     3516     +757     
+ Misses       1324     1142     -182     
- Partials      332      351      +19     
Flag Coverage Δ
e2etests 21.39% <37.03%> (?)
unit-test 64.22% <85.18%> (+1.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Amit Singh <singhamitch@outlook.com>
@semmet95 semmet95 force-pushed the chore/import-shared-crds branch from cc17802 to 87af26e Compare October 16, 2025 06:02
@semmet95 semmet95 marked this pull request as ready for review October 16, 2025 06:08
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 24 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="Makefile">

<violation number="1" location="Makefile:38">
Adding sync-crds here makes every manifests invocation run go mod tidy, so `make test` (and other targets that depend on manifests) now mutate go.mod/go.sum whenever the module is not already tidy. Please keep tidying as an explicit step instead of coupling it to manifests.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

Signed-off-by: Amit Singh <singhamitch@outlook.com>
@semmet95
Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai re-run

@cubic-dev-ai
Copy link
Copy Markdown

cubic-dev-ai bot commented Oct 16, 2025

@cubic-dev-ai re-run

@semmet95 Sorry, I encountered an error while trying to start the review. Please try again later.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 24 files

Signed-off-by: Amit Singh <singhamitch@outlook.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>
@roguepikachu roguepikachu force-pushed the chore/import-shared-crds branch from 586f80b to 4639216 Compare October 24, 2025 06:08
Signed-off-by: Vishal Kumar <vishal210893@gmail.com>
Co-authored-by: Ayush Kumar <ayushshyamkumar888@gmail.com>
@FogDong FogDong merged commit ee2d740 into kubevela:main Oct 27, 2025
17 checks passed
@semmet95 semmet95 deleted the chore/import-shared-crds branch October 27, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants